fix: guard dashboard update in Docker#34831
Closed
donovan-yohan wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Landed via #36263 (merged in c1a531d) — a rebase of your fix onto current main, resolving the trivial |
JoeKowal
pushed a commit
to JoeKowal/hermes-agent
that referenced
this pull request
Jun 4, 2026
…nce (salvage NousResearch#34831) (NousResearch#36263) * fix: guard dashboard update in Docker * fix(dashboard): align action response type --------- Co-authored-by: Donovan Yohan <donovan-yohan@users.noreply.github.com> Co-authored-by: Donovan Yohan <34756395+donovan-yohan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/hermes/updatebefore spawninghermes update.Closes #34347
Validation
scripts/run_tests.sh tests/hermes_cli/test_cmd_update_docker.py tests/hermes_cli/test_web_server.py -- -q -k 'update_hermes or docker'— 9 passed.venv/bin/python -m compileall -q hermes_cli/web_server.py tests/hermes_cli/test_web_server.py— passedscripts/run_tests.sh tests/hermes_cli/test_web_server.py -- -q— 149 passed, 3 failed in existingTestPtyWebSocketwebsocket/PTY tests under this local ad-hoc venv (test_streams_child_stdout_to_client,test_client_input_reaches_child_stdin,test_resize_escape_is_forwarded); failures are outside the dashboard update endpoint path.