fix(gateway): restart through launchd supervision#34230
Open
chrometh wants to merge 1 commit into
Open
Conversation
Detect launchd-managed gateway processes during /restart and route restarts through the service manager instead of detached helpers. Bootstrap unloaded launchd jobs before self-signalling so macOS restarts do not strand the gateway.
Collaborator
|
I tested #34230 on an affected macOS launchd machine. It fixes the service-manager detection/plist marker, but the early return after graceful SIGUSR1 still stranded launchd as loaded but not running with I opened #34366 with the extra regression + follow-up behavior: after graceful drain, continue to |
This was referenced May 29, 2026
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/restartHERMES_GATEWAY_SERVICE_MANAGER=launchdand bootstrap unloaded jobs before self-signallingTest Plan
PYTHONPATH="$PWD" python -m pytest tests/gateway/test_restart_notification.py tests/hermes_cli/test_gateway.py -q -o 'addopts='\n- also passed combined local patch suite: 131 tests