fix(gateway): detect launchd service for restart#19940
Open
hteo1337 wants to merge 1 commit into
Open
Conversation
This was referenced May 13, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Detects launchd-managed Hermes gateways when handling
/restartfrom the gateway. launchd setsXPC_SERVICE_NAME=ai.hermes.gateway, notINVOCATION_ID, so the previous check only recognized systemd. On macOS this could send/restartdown the detached restart path, exit cleanly, and leave launchd configured withKeepAlive SuccessfulExit=falsewithout a respawn.The fix treats
XPC_SERVICE_NAME == "ai.hermes.gateway"as service-managed and uses the existing service restart path (detached=False,via_service=True).Related Issue
Related to #11932 and the broader launchd restart reliability work, but this is a separate
/restartservice-detection path.Type of Change
Changes Made
gateway/run.pyXPC_SERVICE_NAME=ai.hermes.gatewayin the service-manager detection used by/restart.tests/gateway/test_restart_drain.pyXPC_SERVICE_NAMEin the non-service restart test./restartcallsrequest_restart(detached=False, via_service=True).How to Test
python -m pytest tests/gateway/test_restart_drain.py -o 'addopts=' -qtest_restart_command_under_launchd_uses_service_restartChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs