Skip to content

fix(doctor): attach codex cli hint to codex auth#28186

Closed
outsourc-e wants to merge 1 commit into
NousResearch:mainfrom
outsourc-e:fix/issue-28007-codex-cli-hint
Closed

fix(doctor): attach codex cli hint to codex auth#28186
outsourc-e wants to merge 1 commit into
NousResearch:mainfrom
outsourc-e:fix/issue-28007-codex-cli-hint

Conversation

@outsourc-e

@outsourc-e outsourc-e commented May 18, 2026

Copy link
Copy Markdown
Contributor

Clean replacement for #28007 without the unrelated release-author mapping commit.

Keeps:

  • doctor output hint attached to the Codex auth check instead of reading like MiniMax advice
  • focused regression coverage in tests/hermes_cli/test_doctor.py

Excludes:

  • unrelated scripts/release.py author-map churn

Validation:

  • scripts/run_tests.sh tests/hermes_cli/test_doctor.py -k codex
  • 1 passed

@outsourc-e outsourc-e mentioned this pull request May 18, 2026
Closed
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels May 18, 2026
@teknium1 teknium1 mentioned this pull request May 19, 2026
Merged
@teknium1

teknium1 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Closing as duplicate of #27986 by @xxxigm, which has been merged via salvage PR #28595 (commit 12c3983). All three of you (#27986, #28007, #28186) submitted the same fix; @xxxigm submitted first. Thanks for the contribution; the fix is on main with credit shared in the salvage PR.

@teknium1 teknium1 closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@outsourc-e @teknium1 @alt-glitch @worlldz