fix(doctor): attach codex cli hint to codex auth#28007
Conversation
b6c2a1d to
244400e
Compare
|
BoardJames triage: I do not see a branch-local failure at the moment. Attribution, common-ancestor, ruff/ty, ruff enforcement, Windows footguns, nix ubuntu/macos, supply-chain, e2e, and both Docker builds are green. The only non-green item I see is the full |
outsourc-e
left a comment
There was a problem hiding this comment.
The doctor fix itself looks good, but this branch also includes unrelated scripts/release.py author-map churn.
I opened a clean replacement with only the doctor-output fix and test coverage:
Validation on the clean replacement:
scripts/run_tests.sh tests/hermes_cli/test_doctor.py -k codex- 1 passed
|
Closing as duplicate of #27986 by @xxxigm, which has been merged via salvage PR #28595 (commit 12c3983). All three of you (#27986, #28007, #28186) submitted the same fix in parallel — @xxxigm by ~27 minutes first, but you both spotted the same UX bug. Thanks for the contribution; the fix is on main with credit shared in the salvage PR. |
Fixes #27975
hermes doctorcurrently prints the optionalcodex CLI not installedimport hint after theMiniMax OAuthline, which makes it read like MiniMax-related guidance.This patch attaches that hint directly to the
OpenAI Codex authwarning instead, which is the only place where it is actually relevant.Validation:
uv run --extra dev pytest tests/hermes_cli/test_doctor.py -q -k codex_cli_hintResult:
1 passed in 11.88s