fix(tools): add return_exceptions to asyncio.gather in web_tools#2751
Closed
nidhi-singh02 wants to merge 1 commit into
Closed
fix(tools): add return_exceptions to asyncio.gather in web_tools#2751nidhi-singh02 wants to merge 1 commit into
nidhi-singh02 wants to merge 1 commit into
Conversation
Prevents a single failing LLM summarization task from discarding all other successfully fetched results. Each gather call now gracefully skips failed tasks and logs warnings.
teknium1
added a commit
that referenced
this pull request
May 15, 2026
PR #2751 salvage. CI requires AUTHOR_MAP coverage for all contributor commit emails.
Contributor
|
Merged via #26244 — your commit was cherry-picked onto current main with your authorship preserved in git log (eacb398). The 4th call site your PR touched had been removed when firecrawl crawl moved to its plugin, so we applied the fix to the remaining 3 sites and cleaned up the chunk-summarize sort key. Thanks for the contribution! 🙏 |
DIZ-admin
pushed a commit
to DIZ-admin/hermes-agent
that referenced
this pull request
May 16, 2026
PR NousResearch#2751 salvage. CI requires AUTHOR_MAP coverage for all contributor commit emails.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
PR NousResearch#2751 salvage. CI requires AUTHOR_MAP coverage for all contributor commit emails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return_exceptions=Trueto all 4asyncio.gather()calls intools/web_tools.pyBaseExceptioninstances from results with warning-level loggingCloses #2744
Test Plan
Platforms Tested