fix(gateway): preserve spaced unicode media paths from tool output#26407
Open
aqilaziz wants to merge 3 commits into
Open
fix(gateway): preserve spaced unicode media paths from tool output#26407aqilaziz wants to merge 3 commits into
aqilaziz wants to merge 3 commits into
Conversation
Collaborator
55ff5f7 to
76d6c5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the novel MEDIA extraction part of #26355: gateway tool-output scanning now preserves local media paths that contain spaces and non-ASCII filenames instead of truncating them with
MEDIA:(\S+).Changes
BasePlatformAdapter.extract_media()when scanning persisted tool output for MEDIA paths..oggfilename with a space inside a JSON tool result.Addresses #26355 (Bug 1: Cyrillic/spaced MEDIA paths lost during extraction)
Tests
python -m pytest -o addopts= tests\gateway\test_media_extraction.py tests\gateway\test_platform_base.py::TestExtractMedia tests\gateway\test_tts_media_routing.py -q --tb=shortpython -m ruff check gateway\run.py tests\gateway\test_media_extraction.pygit diff --check