fix(gateway): parse Windows media paths with spaces#26368
Closed
aqilaziz wants to merge 3 commits into
Closed
Conversation
Collaborator
This was referenced May 30, 2026
Closed
Contributor
|
This looks implemented on current Automated hermes-sweeper review evidence:
Thanks for calling out the Cyrillic/space filename case; the current extractor behavior covers it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MEDIA:paths that include spaces and Unicode characters, e.g.C:\Users\Иван Иванов\voice file.ogg.Related Issue
Related to #26355 (Bug 1: Cyrillic filenames / path parsing in
extract_media). I did not mark the whole issue as closing because the issue also mentions auto-voice.mp3/ OGG delivery items that maintainers identified as duplicates or covered by other PRs.Test Plan
python -m pytest -o addopts= tests\gateway\test_platform_base.py -q --tb=shortpython -m pytest -o addopts= tests\gateway\test_platform_base.py tests\run_agent\test_provider_parity.py::TestDeveloperRoleSwap::test_developer_role_via_nous_portal tests\run_agent\test_provider_parity.py::TestBuildApiKwargsNousPortal::test_includes_nous_product_tags tests\run_agent\test_provider_parity.py::TestBuildApiKwargsNousPortal::test_uses_chat_completions_format tests\gateway\test_discord_free_response.py::test_fetch_channel_context_returns_empty_when_channel_lacks_history tests\e2e\test_discord_adapter.py -q --tb=shortpython -m ruff check gateway\platforms\base.py tests\gateway\test_platform_base.py tests\run_agent\test_provider_parity.py tests\gateway\test_discord_free_response.py tests\e2e\test_discord_adapter.py gateway\platforms\discord.pygit diff --check HEAD~3..HEAD