fix(kanban): use colLabel instead of undefined COLUMN_LABEL#23701
Closed
HanVertegaal wants to merge 1 commit into
Closed
fix(kanban): use colLabel instead of undefined COLUMN_LABEL#23701HanVertegaal wants to merge 1 commit into
HanVertegaal wants to merge 1 commit into
Conversation
…abel The column select-all checkbox aria-label referenced the undefined COLUMN_LABEL map instead of the already-computed colLabel local. Introduced in 3df7e30 (shift-click / select-all toggle).
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
So, when will this be merged. I have same issue. |
Collaborator
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The column select-all checkbox in the kanban dashboard crashes with:
This is because the aria-label references the undefined
COLUMN_LABELmap instead of the already-computedcolLabellocal variable.Fix
Replace:
`Select all tasks in ${COLUMN_LABEL[props.column.name] || props.column.name}`With:
`Select all tasks in ${colLabel || props.column.name}`Root cause
Commit 3df7e30 introduced the column select-all checkbox but used the wrong variable name. The
colLabellocal (computed viagetColumnLabel(t, props.column.name)) was already available and correct — it just wasn't used.