Skip to content

fix: correct gemini doctor api-key probe#22468

Closed
Jeffgithub0029 wants to merge 1 commit into
NousResearch:mainfrom
Jeffgithub0029:fix/gemini-doctor-api-key-probe
Closed

fix: correct gemini doctor api-key probe#22468
Jeffgithub0029 wants to merge 1 commit into
NousResearch:mainfrom
Jeffgithub0029:fix/gemini-doctor-api-key-probe

Conversation

@Jeffgithub0029

Copy link
Copy Markdown

Summary

  • teach hermes doctor to authenticate Google AI Studio checks with x-goog-api-key
  • avoid false invalid API key reports for valid Gemini keys
  • add regression coverage for the Gemini doctor probe

Testing

  • python -m pytest tests/hermes_cli/test_doctor.py -k "gemini or dashscope or opencode_go or kimi_cn" -o "addopts=" -q
  • hermes doctor

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard provider/gemini Google Gemini (AI Studio, Cloud Code) P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels May 11, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #20642 — same fix (use x-goog-api-key header for Gemini doctor probe). Already triaged duplicates: #22489, #22286.

@teknium1

Copy link
Copy Markdown
Contributor

Closing as superseded by #11961.

Triage notes (high confidence):
Merged PR #11961 'fix(gemini): route Google AI Studio auth via x-goog-api-key header' already added the x-goog-api-key branch in doctor.py at line 1549 for generativelanguage.googleapis.com.

Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen.

(Bulk-closed during a CLI PR triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have provider/gemini Google Gemini (AI Studio, Cloud Code) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants