fix: correct gemini doctor api-key probe#22489
Closed
Jeffgithub0029 wants to merge 1 commit into
Closed
Conversation
Author
|
This PR comes from a fork, so GitHub Actions appear to be waiting for maintainer approval before any jobs can start. Once approved, I’ll follow up on the checks. |
Collaborator
This was referenced May 11, 2026
Contributor
|
Closing as already fixed on Triage notes (high confidence): If you still see this on the latest version, please reopen with reproduction steps. (Bulk-closed during a CLI triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-goog-api-keyinstead ofAuthorization: Bearerwhen doctor probes Google AI Studio Gemini endpointsWhy
Google AI Studio API keys are rejected when sent as
Authorization: Bearer ...togenerativelanguage.googleapis.com, which madehermes doctorreport valid Gemini keys as invalid even though real Hermes requests worked.Test Plan
python -m pytest tests/hermes_cli/test_doctor.py -o 'addopts=' -q\n- [x]hermes doctorshows✓ geminiwith a validGOOGLE_API_KEY\n- [x]hermes chat --provider gemini --model gemini-2.5-flash -q 'Reply with exactly: HERMES_GEMINI_OK_AFTER_PATCH'\n