Skip to content

fix(doctor): probe native gemini keys correctly#22286

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/21481-doctor-gemini-key-check
Closed

fix(doctor): probe native gemini keys correctly#22286
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/21481-doctor-gemini-key-check

Conversation

@LeonSGP43

@LeonSGP43 LeonSGP43 commented May 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use x-goog-api-key when hermes doctor probes native Gemini API endpoints
  • keep Bearer auth for OpenAI-compatible / proxy-style endpoints
  • add a regression test so doctor no longer marks a valid Google AI Studio key as invalid

Closes #21481

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard provider/gemini Google Gemini (AI Studio, Cloud Code) duplicate This issue or pull request already exists labels May 9, 2026
@alt-glitch

alt-glitch commented May 9, 2026

Copy link
Copy Markdown
Collaborator

Duplicate of #20642 — same fix (use x-goog-api-key header for native Gemini API endpoints in hermes doctor). #20642 already implements this alongside other fixes.

This was referenced May 10, 2026
Closed
Closed
Closed
Closed
@therahul-yo therahul-yo mentioned this pull request May 16, 2026
Closed
@alt-glitch alt-glitch mentioned this pull request May 16, 2026
Closed
3 tasks
@teknium1

teknium1 commented May 24, 2026

Copy link
Copy Markdown
Contributor

Closing as already fixed on main.

Triage notes (high confidence):
main hermes_cli/doctor.py:1549-1551 already pops Authorization and sets x-goog-api-key for generativelanguage.googleapis.com URLs, fixing the native Gemini probe (implemented via host-match rather than is_native_gemini_base_url, but functionally equivalent).

If you still see this on the latest version, please reopen with reproduction steps.

(Bulk-closed during a CLI triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have provider/gemini Google Gemini (AI Studio, Cloud Code) type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: hermes doctor falsely reports valid Google AI Studio Gemini API key as invalid

3 participants

@LeonSGP43 @alt-glitch @teknium1