Skip to content

docs(teams): split meetings setup from operator runbook#21412

Closed
dlkakbs wants to merge 15 commits into
NousResearch:mainfrom
dlkakbs:pr/teams-meetings-docs
Closed

docs(teams): split meetings setup from operator runbook#21412
dlkakbs wants to merge 15 commits into
NousResearch:mainfrom
dlkakbs:pr/teams-meetings-docs

Conversation

@dlkakbs

@dlkakbs dlkakbs commented May 7, 2026

Copy link
Copy Markdown
Contributor

References PR #19815.

This is the fifth and final part of the Microsoft Teams meeting pipeline stack, split out in response to maintainer review on the original PR.

This slice is intentionally scoped to:

  • splitting the Teams meetings documentation into setup and operator runbook sections
  • adding the skills/productivity/teams-meeting-pipeline/SKILL.md asset for the CLI + skill workflow
  • the small async test-environment follow-up needed for the stacked rollout

This follows the maintainer review direction to keep setup and environment guidance on the main page while moving operator runbook/checklist material into a dedicated guide, and to route operator usage through the CLI + skill pattern rather than exposing extra model tools.

The goal here is to keep the final docs and skill follow-up isolated from the runtime and delivery code paths.

Review and merge in stack order.

@alt-glitch alt-glitch added type/docs Documentation improvements comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have labels May 7, 2026
@dlkakbs dlkakbs marked this pull request as draft May 7, 2026 16:31
@dlkakbs dlkakbs marked this pull request as ready for review May 7, 2026 21:03
@dlkakbs dlkakbs force-pushed the pr/teams-meetings-docs branch from 37de7a7 to 5aa3226 Compare May 7, 2026 21:57
@teknium1

teknium1 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Leaving the same note on the other PRs in the stack for visibility.

Could you retarget this PR's base branch so diffs are incremental instead of cumulative? Full detail in #21408 (comment) but tl;dr:

gh pr edit <N> --base <branch> does it in place — no close/reopen, comments and CI preserved. GitHub auto-retargets up the stack as each one merges.

Planning to review bottom-up from #21408. Thanks.

@teknium1

teknium1 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Merged via PR #22042. Your two commits (docs(teams): split meetings setup from operator runbook and fix(teams-pipeline): add skill asset and fix async test env) landed on main with your authorship preserved via rebase-merge — see commits b79ef8827 and 729a659a3.

One follow-up added on top during salvage:

docs(teams-pipeline): cron renewal recipe, sidebar wiring, skill rewrite — three additions:

  1. Subscription renewal cron recipe in the operator runbook. Microsoft Graph webhook subscriptions expire at 72h max and don't auto-renew, so any production deployment silently stops ingesting meetings three days after go-live without a scheduled maintain-subscriptions job. Added an "Automating subscription renewal (REQUIRED for production)" section with three concrete options (Hermes cron, systemd timer, plain crontab), copy-pasteable configs, and verification steps. Go-Live Checklist gains a bolded mandatory item. Setup page gets a :::warning::: admonition right after the manual subscribe examples.

  2. Sidebar wiring. teams-meetings.md and operate-teams-meeting-pipeline.md weren't in website/sidebars.ts — they were reachable only by knowing the URL. Wired teams-meetings into Messaging Platforms next to teams, and operate-teams-meeting-pipeline into Guides & Tutorials next to microsoft-graph-app-registration from PR feat(msgraph): add auth and client foundation (salvage of #21408) #21922.

  3. SKILL.md rewrite (1.0 → 1.1). The original had five Turkish-only trigger phrases. Rewrote with intent-based trigger descriptions ("works in any language"), example phrases in both English and Turkish, a decision tree for the three most common user asks (missing summary, setup verification, re-run request), a dedicated "Critical pitfall: Graph subscriptions expire in 72 hours" section, three labeled command groups, and cross-links to all four related docs pages.


That closes the entire stack (#21408 foundation → #21409 webhook listener → #21410 pipeline runtime → #21411 outbound delivery → #21412 docs + skill). All five PRs merged with your authorship preserved on every commit you wrote. Thanks for taking the initial review direction on #19815 seriously and splitting the work up the way you did — it made reviewing much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/docs Documentation improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants