Skip to content

feat(teams): add pipeline outbound delivery via existing adapter#21411

Closed
dlkakbs wants to merge 13 commits into
NousResearch:mainfrom
dlkakbs:pr/teams-outbound-delivery
Closed

feat(teams): add pipeline outbound delivery via existing adapter#21411
dlkakbs wants to merge 13 commits into
NousResearch:mainfrom
dlkakbs:pr/teams-outbound-delivery

Conversation

@dlkakbs

@dlkakbs dlkakbs commented May 7, 2026

Copy link
Copy Markdown
Contributor

References PR #19815.

This is the fourth part of the Microsoft Teams meeting pipeline stack, split out in response to maintainer review on the original PR.

This slice is intentionally scoped to:

  • outbound Teams delivery for the meeting pipeline
  • integration through the existing Teams adapter
  • removal of the redundant delivery-mode branch introduced during the refactor

This follows the maintainer review direction to keep outbound Teams delivery in the existing Teams adapter surface rather than introducing a second competing adapter path.

The goal here is to land the delivery layer separately from the pipeline runtime and ahead of the docs-only follow-up PR in the stack.

Review and merge in stack order.

@alt-glitch alt-glitch added type/feature New feature or request comp/plugins Plugin system and bundled plugins comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have labels May 7, 2026
@dlkakbs dlkakbs marked this pull request as draft May 7, 2026 16:31
@dlkakbs dlkakbs marked this pull request as ready for review May 7, 2026 21:03
@dlkakbs dlkakbs force-pushed the pr/teams-outbound-delivery branch from ab54782 to 0dbeab2 Compare May 7, 2026 21:57
@teknium1

teknium1 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Leaving the same note on the other PRs in the stack for visibility.

Could you retarget this PR's base branch so diffs are incremental instead of cumulative? Full detail in #21408 (comment) but tl;dr:

gh pr edit <N> --base <branch> does it in place — no close/reopen, comments and CI preserved. GitHub auto-retargets up the stack as each one merges.

Planning to review bottom-up from #21408. Thanks.

@teknium1

teknium1 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Merged via PR #22024. Your two commits (feat(teams): add pipeline outbound delivery via existing adapter and refactor(teams): remove redundant delivery-mode branch) landed on main with your authorship preserved via rebase-merge — see commits 397f750bb and d36ccc29c.

Two small follow-ups added on top during salvage:

  1. fix(teams-pipeline): fill in missing delivery URL in adapter-reuse testtest_build_pipeline_runtime_reuses_existing_teams_adapter_surface set delivery_mode="incoming_webhook" but omitted incoming_webhook_url. The guarded build_pipeline_runtime gate (which calls _teams_delivery_is_configured) correctly left teams_sender=None in that case, so the isinstance(runtime.teams_sender, FakeWriter) assertion failed. The test's architectural intent — prove we reuse the existing adapter surface rather than introducing a new one — is unchanged. Added the URL so the gate passes and the assertion holds.

  2. docs(teams): meeting summary delivery section + env var reference/docs/user-guide/messaging/teams gains a "Meeting Summary Delivery (Teams Meeting Pipeline)" section under Features with a config-snippet example, a mode-choice trade-off table (incoming_webhook vs graph), and an explicit note that settings are inert when the teams_pipeline plugin is disabled. Env var reference gains a Teams Meeting Summary Delivery subsection documenting TEAMS_DELIVERY_MODE, TEAMS_INCOMING_WEBHOOK_URL, TEAMS_GRAPH_ACCESS_TOKEN, TEAMS_TEAM_ID, TEAMS_CHANNEL_ID, TEAMS_CHAT_ID.

End-to-end after this PR: msgraph_webhook receives Graph's "meeting ended" notification → teams_pipeline runtime resolves the transcript → agent summarizes → TeamsSummaryWriter posts the summary back into Teams via the configured mode. That's the full loop.

Final PR in the stack (#21412 — full setup docs + operator runbook + SKILL.md) is next. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants