fix(slack): enable writable App Home DMs in manifest#20503
Closed
dandacompany wants to merge 1 commit into
Closed
Conversation
teknium1
added a commit
that referenced
this pull request
May 9, 2026
Contributor
|
Your commit was cherry-picked onto current main with authorship preserved via rebase-merge, so |
JZKK720
pushed a commit
to JZKK720/hermes-agent
that referenced
this pull request
May 11, 2026
rmulligan
pushed a commit
to rmulligan/hermes-agent
that referenced
this pull request
May 11, 2026
JinyuID
pushed a commit
to JinyuID/hermes-agent
that referenced
this pull request
May 11, 2026
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
May 25, 2026
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
features.app_hometo the generated full Slack app manifest so App Home DMs are enabled and writable by default.groups:readto the generated bot scopes so private-channel directory enumeration has the scope it already expects.hermes slack manifestoutput while preserving the existing Slack Assistant manifest fields.Context
The Slack setup docs already call out that the Messages Tab must be enabled, otherwise users see "Sending messages to this app has been turned off" when trying to DM the bot. That documentation landed in #3590, but
hermes slack manifest --writedid not encode the same App Home setting, so users following the recommended manifest path could still create an app with blocked DMs.This keeps the existing assistant UX (
assistant_view,assistant:write, and assistant thread events) intact; it only makes the generated manifest match the documented DM setup requirement.Related to #17054.
Tests
uv run --extra dev pytest tests/hermes_cli/test_slack_cli.py tests/hermes_cli/test_commands.py::TestSlackAppManifest -quv run --extra dev ruff check hermes_cli/slack_cli.py tests/hermes_cli/test_slack_cli.py