fix(slack): enable writable app home DMs in manifest#22145
Merged
Conversation
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #20503 onto current main.
Cherry-picks @dandacompany's fix that makes
hermes slack manifest --writeproduce a manifest Slack will actually accept for the App Home Messages tab + private channel enumeration.Changes
hermes_cli/slack_cli.py:_build_full_manifest()now setsfeatures.app_home(messages_tab_enabled=True,messages_tab_read_only_enabled=False) and addsgroups:readto bot scopes.tests/hermes_cli/test_slack_cli.py: 3 new tests pin the behavior.scripts/release.py: AUTHOR_MAP entry for datapod.k@gmail.com → dandacompany.Validation
scripts/run_tests.sh tests/hermes_cli/test_slack_cli.py→ 3/3 pass.Closes #20503 — credit to @dandacompany, authorship preserved via rebase-merge.