fix: sync ui-tui lockfile for npm ci#18577
Conversation
|
Related to #18573 (same lockfile refresh pattern). Consider consolidating with that PR. |
|
Related to #18573 (same lockfile refresh pattern). |
|
I can reproduce the lockfile side of this on a native Linux checkout from current Environment:
Evidence from current The specific mismatch is visible here:
Since In my local update logs this repeats across several updates with stashes containing So PR #18577 looks like the right direction for the lockfile part of the problem. It should stop the update path from falling back to mutating One related update-path concern: after dependency refresh, cd ui-tui
npm run build --prefix packages/hermes-ink
npm run buildIf this PR is intended to solve only the lockfile issue, it may be worth tracking the explicit |
|
This looks implemented on current Evidence from this automated hermes-sweeper review:
The useful reproduction/comment thread here matched the old per- |
Summary
ui-tui/package-lock.jsonso it is in sync with the current dependency graph.@emnapi/coreand@emnapi/runtimerequired through the Rolldown/Vite dependency chain.npm cipath succeed instead of falling back tonpm install, which can dirty the working tree by rewriting the lockfile.Verification
cd ui-tui && npm ci --silent --no-fund --no-audit --progress=falsecd ui-tui && npm run type-checkpython -m pytest tests/hermes_cli/test_tui_npm_install.py -q -o 'addopts='Note: I also ran
tests/hermes_cli/test_cmd_update.pytogether with the TUI npm install tests. The TUI npm install tests passed, but one existing update test failed locally because this checkout includes aweb/directory while the test expectation only included repo root andui-tuinpm calls.