Skip to content

fix(discord): remove bugged followup messages + remove /ask command#1836

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-ba3c8fa1
Mar 17, 2026
Merged

fix(discord): remove bugged followup messages + remove /ask command#1836
teknium1 merged 2 commits into
mainfrom
hermes/hermes-ba3c8fa1

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks PR #1827 by @CharlieKerfoot (followup fix) and removes the redundant /ask slash command.

Followup fix (from #1827):
Discord slash commands (/reasoning, /voice) were sending unnecessary "Done~" or "Processing complete~" followup messages after the actual agent response was already sent via the normal adapter flow. Sometimes these followups replaced the real response. Fix: change _run_simple_slash default followup_msg from "Done~" to None so only commands that explicitly need a followup (/new, /reset, /update) send one.

/ask removal:
/ask was just "send a message to the bot" via the slash command menu — completely redundant since Discord bots already listen to channel messages. Removed.

Supersedes #1827.

Test plan

  • python -m pytest tests/gateway/ -n0 -q — 1194 passed (2 pre-existing whatsapp failures, unrelated)

CharlieKerfoot and others added 2 commits March 17, 2026 16:24
/ask was just 'send a message to the bot' via the slash command menu —
completely redundant since Discord bots already listen to channel messages.
Removed as part of salvaging PR #1827.
@teknium1 teknium1 merged commit 8d60db0 into main Mar 17, 2026
1 check failed
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
…ousResearch#1836)

fix(discord): remove bugged followup messages + remove /ask command
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…ousResearch#1836)

fix(discord): remove bugged followup messages + remove /ask command
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
…ousResearch#1836)

fix(discord): remove bugged followup messages + remove /ask command
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
…ousResearch#1836)

fix(discord): remove bugged followup messages + remove /ask command
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
…ousResearch#1836)

fix(discord): remove bugged followup messages + remove /ask command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants