Skip to content

fix(discord): remove bugged follow up messages from discord slash commmands#1827

Closed
CharlieKerfoot wants to merge 1 commit into
NousResearch:mainfrom
CharlieKerfoot:fix/discord-slash-followup-messages
Closed

fix(discord): remove bugged follow up messages from discord slash commmands#1827
CharlieKerfoot wants to merge 1 commit into
NousResearch:mainfrom
CharlieKerfoot:fix/discord-slash-followup-messages

Conversation

@CharlieKerfoot

@CharlieKerfoot CharlieKerfoot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Discord slash commands (/ask, /reasoning, /voice) were sending unnecessary "Done~" or "Processing
    complete~" followup messages, even though the actual agent response is sent separately via the normal
    adapter flow
  • Sometimes these messages would replace the actual agent response, resulting in a completely broken discord gateway.
  • Changed _run_simple_slash default followup_msg from "Done~" to None so only commands that explicitly
    pass a message (e.g. /new, /reset, /update) send a followup
  • Removed redundant followup sends from slash_ask, slash_reasoning, and slash_voice

Test plan

  • Run /ask (or any slash command) in Discord and verify only the agent's response appears (no "Processing complete~" or "Done~")

teknium1 pushed a commit that referenced this pull request Mar 17, 2026
/ask was just 'send a message to the bot' via the slash command menu —
completely redundant since Discord bots already listen to channel messages.
Removed as part of salvaging PR #1827.
@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #1836. Your followup fix was cherry-picked onto current main with authorship preserved. Also removed the redundant /ask slash command on top. Thanks for catching this!

@teknium1 teknium1 closed this Mar 17, 2026
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
/ask was just 'send a message to the bot' via the slash command menu —
completely redundant since Discord bots already listen to channel messages.
Removed as part of salvaging PR NousResearch#1827.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
/ask was just 'send a message to the bot' via the slash command menu —
completely redundant since Discord bots already listen to channel messages.
Removed as part of salvaging PR NousResearch#1827.
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
/ask was just 'send a message to the bot' via the slash command menu —
completely redundant since Discord bots already listen to channel messages.
Removed as part of salvaging PR NousResearch#1827.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
/ask was just 'send a message to the bot' via the slash command menu —
completely redundant since Discord bots already listen to channel messages.
Removed as part of salvaging PR NousResearch#1827.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
/ask was just 'send a message to the bot' via the slash command menu —
completely redundant since Discord bots already listen to channel messages.
Removed as part of salvaging PR NousResearch#1827.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants