fix(status): add NVIDIA_API_KEY to hermes status API keys display#18067
Closed
Feranmi10 wants to merge 2 commits into
Closed
fix(status): add NVIDIA_API_KEY to hermes status API keys display#18067Feranmi10 wants to merge 2 commits into
Feranmi10 wants to merge 2 commits into
Conversation
…call When a fallback_model entry names a provider defined in custom_providers but omits an explicit base_url, the resolution path skipped the custom_providers lookup entirely. If the provider name happened to alias to a built-in (e.g. "kimi" -> "kimi-coding"), _get_named_custom_provider would return None inside resolve_provider_client (because auth.resolve_provider succeeds for aliases and short-circuits the search), and the code fell through to the PROVIDER_REGISTRY path which used the built-in endpoint — typically the same as the primary provider's base_url. Fix (_try_activate_fallback in run_agent.py): when fb_base_url_hint is absent, call _get_named_custom_provider with the original fb_provider name (pre-normalization) so the custom_providers entry is found even when the name aliases to a registered built-in. api_key and key_env are resolved from the same entry. Fix (resolve_provider_client in agent/auxiliary_client.py): in the API-key provider path, honour explicit_base_url and explicit_api_key when provided so that the correct custom endpoint is used even after the provider name has been normalised to a built-in alias.
Fixes NousResearch#16082 — NVIDIA_API_KEY was absent from the API Keys section of `hermes status` output despite nvidia being a supported provider.
Collaborator
1 similar comment
Collaborator
Contributor
|
Merged via #18168 with your NVIDIA status fix — your commit authorship is preserved in git log. Thanks @Feranmi10! Scoped the salvage down to just the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes missing NVIDIA API key status in the
hermes statusoutput.The
hermes statuscommand displays a list of configured provider API keys in the ◆ API Keys section, butNVIDIA_API_KEYwas absent from the list. Users who configure NVIDIA NIM as their provider had no way to verify their key was set correctly from the status output.Fix: Added
"NVIDIA": "NVIDIA_API_KEY"to thekeysdict inhermes_cli/status.pyalongside the other inference provider keys.Related Issue
Fixes #16082
Type of Change