Skip to content

fix(status): add NVIDIA_API_KEY to hermes status API keys display#18067

Closed
Feranmi10 wants to merge 2 commits into
NousResearch:mainfrom
Feranmi10:fix/status-nvidia-api-key
Closed

fix(status): add NVIDIA_API_KEY to hermes status API keys display#18067
Feranmi10 wants to merge 2 commits into
NousResearch:mainfrom
Feranmi10:fix/status-nvidia-api-key

Conversation

@Feranmi10

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes missing NVIDIA API key status in the hermes status output.

The hermes status command displays a list of configured provider API keys in the ◆ API Keys section, but NVIDIA_API_KEY was absent from the list. Users who configure NVIDIA NIM as their provider had no way to verify their key was set correctly from the status output.

Fix: Added "NVIDIA": "NVIDIA_API_KEY" to the keys dict in hermes_cli/status.py alongside the other inference provider keys.

Related Issue

Fixes #16082

Type of Change

  • Bug fix

…call

When a fallback_model entry names a provider defined in custom_providers
but omits an explicit base_url, the resolution path skipped the
custom_providers lookup entirely.  If the provider name happened to alias
to a built-in (e.g. "kimi" -> "kimi-coding"), _get_named_custom_provider
would return None inside resolve_provider_client (because auth.resolve_provider
succeeds for aliases and short-circuits the search), and the code fell
through to the PROVIDER_REGISTRY path which used the built-in endpoint —
typically the same as the primary provider's base_url.

Fix (_try_activate_fallback in run_agent.py): when fb_base_url_hint is
absent, call _get_named_custom_provider with the original fb_provider name
(pre-normalization) so the custom_providers entry is found even when the
name aliases to a registered built-in.  api_key and key_env are resolved
from the same entry.

Fix (resolve_provider_client in agent/auxiliary_client.py): in the
API-key provider path, honour explicit_base_url and explicit_api_key when
provided so that the correct custom endpoint is used even after the
provider name has been normalised to a built-in alias.
Fixes NousResearch#16082 — NVIDIA_API_KEY was absent from the API Keys section of
`hermes status` output despite nvidia being a supported provider.
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard provider/nvidia NVIDIA NIM labels Apr 30, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #16143 (same single-provider fix) and subset of #16159 (superset adding multiple missing provider keys). Consider closing in favor of #16159.

1 similar comment
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #16143 (same single-provider fix) and subset of #16159 (superset adding multiple missing provider keys). Consider closing in favor of #16159.

@teknium1

teknium1 commented May 1, 2026

Copy link
Copy Markdown
Contributor

Merged via #18168 with your NVIDIA status fix — your commit authorship is preserved in git log. Thanks @Feranmi10!

Scoped the salvage down to just the hermes_cli/status.py change. The custom_providers fallback chunks in agent/auxiliary_client.py / run_agent.py were left out since they overlap with your other PR #17827 and @briandevans's #15756 — those can land separately.

@teknium1 teknium1 closed this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have provider/nvidia NVIDIA NIM type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: hermes status missing some api key status, like nvidia api key is missing, please check and improve it.

3 participants