fix(status): add NVIDIA_API_KEY to hermes status API keys display#18168
Merged
Conversation
Closes #16082 The `hermes status` command listed provider API keys under the ◆ API Keys section but NVIDIA_API_KEY was absent. Users configured with NVIDIA NIM had no way to verify their key was set from status output. Add it alongside the other inference provider keys.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16082. Salvaged from #18067 (@Feranmi10, commit authorship preserved).
hermes statuslisted provider API keys under the ◆ API Keys section butNVIDIA_API_KEYwas absent. Users on NVIDIA NIM had no way to verify their key from status output.Changes
hermes_cli/status.py: add"NVIDIA": "NVIDIA_API_KEY"to the keys dict.Why not merge #18067 directly
#18067 also included ~25 lines of unrelated custom_providers fallback changes in
agent/auxiliary_client.pyandrun_agent.pythat duplicate the same author's PR #17827 and overlap with #15756. Scoping this PR down to just the NVIDIA status fix; the fallback work can be handled separately via #17827 / #15756.