fix(status): add missing popular provider API keys to hermes status by briandevans · Pull Request #16159 · NousResearch/hermes-agent

briandevans · 2026-04-26T17:47:31Z

Summary

hermes status was silently omitting four widely-used LLM providers from both its API Keys and API-Key Providers sections, even though all four are fully registered in PROVIDER_REGISTRY with api_key_env_vars defined:

Provider	Env var(s)
Google / Gemini	`GOOGLE_API_KEY`, `GEMINI_API_KEY`
DeepSeek	`DEEPSEEK_API_KEY`
xAI / Grok	`XAI_API_KEY`
NVIDIA NIM	`NVIDIA_API_KEY`

Each entry is added to both sections:

API Keys — shows the redacted key value so users can confirm the variable is set
API-Key Providers — shows configured/not-configured with the same multi-var fallback pattern used by existing entries (e.g. Z.AI/GLM checks three env vars)

Note: PR #16143 adds only NVIDIA to the API Keys section (+1 line). This PR is a broader fix that covers all four missing providers across both display sections.

Test plan

Run hermes status with NVIDIA_API_KEY, DEEPSEEK_API_KEY, XAI_API_KEY, and GOOGLE_API_KEY set — confirm each appears with ✓ and a redacted value in both sections
Run hermes status without those env vars — confirm each appears with ✗ and (not set) / not configured
Confirm existing entries (OpenRouter, OpenAI, GLM, Kimi, MiniMax) are unaffected

🤖 Generated with Claude Code

Adds Google/Gemini, DeepSeek, xAI/Grok, and NVIDIA NIM to both the "API Keys" display section and the "API-Key Providers" section. All four are present in PROVIDER_REGISTRY with api_key_env_vars set but were absent from status output. Closes NousResearch#16082 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Updates hermes status to surface additional API-key based providers that were previously missing from the status output, addressing #16082.

Changes:

Add Google/Gemini, DeepSeek, xAI/Grok, and NVIDIA NIM to the API Keys section.
Add the same providers to the API-Key Providers section (including multi-env-var support for Gemini).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-26T17:50:07Z

    keys = {
        "OpenRouter": "OPENROUTER_API_KEY",
        "OpenAI": "OPENAI_API_KEY",
+        "Google/Gemini": "GOOGLE_API_KEY",


The provider label for Gemini is inconsistent between sections ("Google/Gemini" in API Keys vs "Google / Gemini" in API-Key Providers). Since these two sections are meant to correspond, consider using the same label string in both places to avoid user confusion and make grep-based troubleshooting easier.

Suggested change

"Google/Gemini": "GOOGLE_API_KEY",

"Google / Gemini": "GOOGLE_API_KEY",

Copilot · 2026-04-26T17:50:07Z

    apikey_providers = {
+        "Google / Gemini":  ("GOOGLE_API_KEY", "GEMINI_API_KEY"),
+        "DeepSeek":         ("DEEPSEEK_API_KEY",),
+        "xAI / Grok":       ("XAI_API_KEY",),
+        "NVIDIA NIM":       ("NVIDIA_API_KEY",),


hermes_cli/status.py has unit tests (e.g. tests/hermes_cli/test_status.py) asserting API key redaction and presence in output, but this change adds new provider rows without tests. Add tests covering at least: (1) GOOGLE_API_KEY vs GEMINI_API_KEY fallback in the API Keys section, and (2) configured/not-configured rendering for DeepSeek/xAI/NVIDIA in both sections.

Copilot · 2026-04-26T17:50:07Z

    keys = {
        "OpenRouter": "OPENROUTER_API_KEY",
        "OpenAI": "OPENAI_API_KEY",
+        "Google/Gemini": "GOOGLE_API_KEY",


The new "Google/Gemini" API key entry only checks GOOGLE_API_KEY. If a user has GEMINI_API_KEY set (which is supported in PROVIDER_REGISTRY["gemini"].api_key_env_vars), hermes status will still show ✗ (not set). Update this entry to use the same multi-env-var fallback as the API-Key Providers section (or add a dedicated Gemini key row) so either env var is recognized and the displayed redacted value matches the one actually used.

Suggested change

"Google/Gemini": "GOOGLE_API_KEY",

"Google/Gemini": ("GOOGLE_API_KEY", "GEMINI_API_KEY"),

…l; add tests Address three Copilot findings on NousResearch#16082: 1. Label inconsistency: "Google/Gemini" in the API Keys dict now matches the "Google / Gemini" spelling used in the API-Key Providers section below it. 2. GEMINI_API_KEY not checked: the Google/Gemini row now accepts either GOOGLE_API_KEY or GEMINI_API_KEY (first found wins), matching PROVIDER_REGISTRY["gemini"].api_key_env_vars. 3. Missing test coverage: adds two new tests — one asserting the new DeepSeek/xAI/NVIDIA rows appear with correct redacted output, one asserting the GEMINI_API_KEY fallback path triggers correctly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

briandevans · 2026-04-26T18:07:32Z

@copilot All 3 findings addressed in commit 3da8ff4:

Label inconsistency (line 123): "Google/Gemini" renamed to "Google / Gemini" to match the spacing in the API-Key Providers section.
GEMINI_API_KEY not checked (line 123): the Google / Gemini row now accepts either GOOGLE_API_KEY or GEMINI_API_KEY (first found wins), matching PROVIDER_REGISTRY["gemini"].api_key_env_vars.
Missing tests (line 268): added test_show_status_new_api_key_providers_appear (verifies DeepSeek, xAI/Grok, NVIDIA NIM rows + redacted output) and test_show_status_gemini_api_key_fallback (verifies GEMINI_API_KEY path when GOOGLE_API_KEY is absent). All 5 tests in tests/hermes_cli/test_status.py pass.

…isplay Closes #16082. `hermes status` silently omitted four widely-used LLM providers (Google/Gemini, DeepSeek, xAI/Grok, NVIDIA NIM) from the API Keys and API-Key Providers sections. Add them, along with tuple-valued env var support (first found wins) so Google can accept either GOOGLE_API_KEY or GEMINI_API_KEY. Also deduplicates the "NVIDIA" and "NVIDIA NIM" rows that were both pointing at NVIDIA_API_KEY. Salvage of #16159 (core behavior preserved + NVIDIA dedup fixup on top of the tuple-support refactor). Co-authored-by: briandevans <252620095+briandevans@users.noreply.github.com>

teknium1 · 2026-05-04T12:14:16Z

Salvaged via #19738 onto current main. Main had picked up a duplicate NVIDIA row from a separate merge; the salvage deduplicates it while applying your broader provider list and tuple-env support. Your authorship was preserved. Thanks @briandevans!

…isplay Closes NousResearch#16082. `hermes status` silently omitted four widely-used LLM providers (Google/Gemini, DeepSeek, xAI/Grok, NVIDIA NIM) from the API Keys and API-Key Providers sections. Add them, along with tuple-valued env var support (first found wins) so Google can accept either GOOGLE_API_KEY or GEMINI_API_KEY. Also deduplicates the "NVIDIA" and "NVIDIA NIM" rows that were both pointing at NVIDIA_API_KEY. Salvage of NousResearch#16159 (core behavior preserved + NVIDIA dedup fixup on top of the tuple-support refactor). Co-authored-by: briandevans <252620095+briandevans@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 26, 2026 17:47

Copilot started reviewing on behalf of briandevans April 26, 2026 17:47 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard provider/deepseek DeepSeek API provider/gemini Google Gemini (AI Studio, Cloud Code) provider/xai xAI (Grok) provider/nvidia NVIDIA NIM labels Apr 26, 2026

alt-glitch mentioned this pull request Apr 30, 2026

fix(status): add NVIDIA_API_KEY to hermes status API keys display #18067

Closed

1 task

teknium1 mentioned this pull request May 4, 2026

fix(status): add missing popular provider API keys to hermes status #19738

Merged

teknium1 closed this May 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(status): add missing popular provider API keys to hermes status#16159

fix(status): add missing popular provider API keys to hermes status#16159
briandevans wants to merge 2 commits into
NousResearch:mainfrom
briandevans:fix/status-missing-provider-keys-16082

briandevans commented Apr 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 26, 2026

Uh oh!

Copilot AI Apr 26, 2026

Uh oh!

Copilot AI Apr 26, 2026

Uh oh!

briandevans commented Apr 26, 2026

Uh oh!

teknium1 commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	"Google/Gemini": "GOOGLE_API_KEY",
	"Google / Gemini": "GOOGLE_API_KEY",

	"Google/Gemini": "GOOGLE_API_KEY",
	"Google/Gemini": ("GOOGLE_API_KEY", "GEMINI_API_KEY"),

Conversation

briandevans commented Apr 26, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

briandevans commented Apr 26, 2026

Uh oh!

teknium1 commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants