fix(slack): config gating, tool_progress default, NO_PROXY support#16288
Merged
Conversation
…env var is set Previously, setting SLACK_BOT_TOKEN in .env would unconditionally enable the Slack gateway adapter regardless of `slack.enabled: false` in config.yaml. This caused spurious "SLACK_APP_TOKEN not set" errors when the token was used only by skills (e.g. cron jobs that send Slack messages) rather than for the Hermes messaging gateway. Now, enabled: false in config.yaml is respected — the token is stored so skills can still use it, but the gateway adapter is not activated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Slack Bolt posts are not editable like CLI spinners; medium-tier new still emitted a permanent line per tool start (issue #14663). - Built-in slack default: off; other tier-2 platforms unchanged. - Adjust /verbose isolation test for off to new cycle. - Migration tests: read/write config.yaml as UTF-8 (Windows locale).
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent Slack config/transport fixes bundled.
1. Respect config.yaml slack.enabled when SLACK_BOT_TOKEN is set
PR #15689 by @haru398801 — 5 lines, gateway/config.py
Previously, setting
SLACK_BOT_TOKENin the environment unconditionally enabled the Slack gateway adapter, overridingslack.enabled: falsein config.yaml. This causedERROR [Slack] SLACK_APP_TOKEN not seton every gateway startup for users who have the bot token available for skills/cron notifications but don't want the full messaging adapter running. Fix: only setenabled=Truewhen there is no existing yaml config; if yaml explicitly setsenabled: false, respect it. Token is still stored so skills can use it.2. Default Slack tool_progress to off
PR #14746 by @xnbi — 18 lines, gateway/display_config.py + tests
Closes #14663. Slack (Bolt/Socket Mode) cannot edit progress lines like the CLI — each becomes a permanent channel message. The tier-medium default of
newwas cluttering public channels. Set Slack-specific override{**_TIER_MEDIUM, "tool_progress": "off"}. Other tier-2 platforms (Mattermost, Matrix, Feishu) unchanged. Users can still enable it globally or per-platform. Also fixes Windowsutf-8encoding assumption in two migration tests.3. Honor NO_PROXY for Slack transport
PR #12011 by @badgerbees — 275 lines, base.py + slack.py + tests
Slack Socket Mode and API calls are proxy-sensitive. Previously, the Slack adapter used whatever global proxy config resolved — including SOCKS proxies that Slack SDKs don't support, and ignoring
NO_PROXYexclusions for slack.com/files.slack.com/wss-primary.slack.com. Fix: newis_host_excluded_by_no_proxyhelper in base.py (supports comma/space-separated entries, leading dots,*.wildcards), new_resolve_slack_proxy_urlin slack.py that rejects non-HTTP(S) schemes and short-circuits when any Slack host is in NO_PROXY, and_apply_slack_proxywiring to AsyncApp/AsyncWebClient/AsyncSocketModeHandler. Per-adapter so other platforms unaffected.Validation
tests/gateway/test_slack.py+test_display_config.py+test_verbose_command.py+test_config.py: 221 passed.Credits
Closes #15689
Closes #14746
Closes #12011
Closes #14663