fix(slack): honor NO_PROXY for Slack transport#12011
Closed
badgerbees wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes Slack proxy behavior in Hermes-agent without changing the rest of the networking stack. Slack traffic now resolves proxy settings locally, only accepts standard HTTP and HTTPS proxies, and disables proxying when NO_PROXY excludes the Slack hosts Hermes actually uses. That keeps the change narrow, preserves existing behavior for other platforms, and avoids introducing extra proxy complexity.
This matters because Slack Socket Mode and API calls are sensitive to proxy configuration. The previous behavior could route Slack through a proxy even when the environment intended Slack to bypass it, or try to use a proxy scheme Slack does not support. The new behavior makes Slack transport predictable across environments and reduces the chance of connection failures caused by proxy configuration drift.
Related Issue
N/A
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs