fix(gateway): default Slack tool_progress to off#14746
Closed
xnbi wants to merge 1 commit into
Closed
Conversation
Slack Bolt posts are not editable like CLI spinners; medium-tier new still emitted a permanent line per tool start (issue NousResearch#14663). - Built-in slack default: off; other tier-2 platforms unchanged. - Adjust /verbose isolation test for off to new cycle. - Migration tests: read/write config.yaml as UTF-8 (Windows locale).
0e710ce to
19ffb88
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slack (Bolt / Socket Mode) cannot treat tool progress like the CLI spinner: each progress line becomes a permanent channel message. The previous built-in default (
newvia_TIER_MEDIUM) still emitted a line on every distinct tool start, which cluttered public channels (see #14663).This PR sets the built-in Slack default to
tool_progress: "off". Other tier-2 platforms (Mattermost, Matrix, Feishu) are unchanged. Users who want progress in Slack can still enable it globally, per-platform underdisplay.platforms.slack, or cycle with/verbosewhendisplay.tool_progress_commandis true.Changes
gateway/display_config.py: Slack uses{**_TIER_MEDIUM, "tool_progress": "off"}with a short comment referencing [Bug]: slack gateway is reporting intermediate tool calls #14663.tests/gateway/test_display_config.py: Split Slack from the “medium tier = new” assertion; addtest_slack_defaults_tool_progress_off. Migration tests now read/writeconfig.yamlwithencoding="utf-8"so they pass on Windows default locale (GBK).tests/gateway/test_verbose_command.py:/verboseisolation test expects Slack’s first cycle to gooff→newinstead ofnew→all.Testing