Skip to content

fix(test): isolate codex provider tests from local env#1335

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-ec1096a3
Mar 14, 2026
Merged

fix(test): isolate codex provider tests from local env#1335
teknium1 merged 2 commits into
mainfrom
hermes/hermes-ec1096a3

Conversation

@teknium1

@teknium1 teknium1 commented Mar 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • salvage PR fix(test): isolate codex provider tests from local env #1037 onto current main by cherry-picking the contributor's test-isolation fixes with authorship preserved
  • prevent test_codex_provider_uses_config_model from hitting live Codex model discovery when local credentials are present
  • clear config-backed model state in the incompatible-default-model Codex test so local user config cannot leak into _model_is_default
  • keep the follow-up fixture shape needed to avoid the base_url KeyError on current main

Test plan

  • python -m pytest tests/test_cli_provider_resolution.py -n0 -q
  • python -m pytest tests/ -n0 -q

Salvages #1037

@teknium1 teknium1 merged commit 60710bc into main Mar 14, 2026
1 check passed
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
…ec1096a3

Salvaged PR NousResearch#1037 onto current main with contributor commits preserved.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…ec1096a3

Salvaged PR NousResearch#1037 onto current main with contributor commits preserved.
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
…ec1096a3

Salvaged PR NousResearch#1037 onto current main with contributor commits preserved.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
…ec1096a3

Salvaged PR NousResearch#1037 onto current main with contributor commits preserved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants