fix(test): isolate codex provider tests from local env#1037
Closed
0xbyt4 wants to merge 2 commits into
Closed
Conversation
teknium1
added a commit
that referenced
this pull request
Mar 14, 2026
Salvaged PR #1037 onto current main with contributor commits preserved.
Contributor
|
Merged via PR #1335. Your substantive test-isolation commits were cherry-picked onto current main with authorship preserved. Thanks for the contribution. |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…ec1096a3 Salvaged PR NousResearch#1037 onto current main with contributor commits preserved.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…ec1096a3 Salvaged PR NousResearch#1037 onto current main with contributor commits preserved.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…ec1096a3 Salvaged PR NousResearch#1037 onto current main with contributor commits preserved.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…ec1096a3 Salvaged PR NousResearch#1037 onto current main with contributor commits preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENAI_API_KEYin~/.hermes/.env)test_codex_provider_uses_config_model:get_codex_model_ids()hits live API which returnsgpt-5.2(no-codexsuffix) as first model, breaking"codex" in shell.modelassertiontest_codex_provider_replaces_incompatible_default_model: localCLI_CONFIGleaks user-configured model, making_model_is_defaultfalseChanges
get_codex_model_idsintest_codex_provider_uses_config_modelto prevent live API callCLI_CONFIG["model"]intest_codex_provider_replaces_incompatible_default_modelto isolate from user configTest plan
pytest tests/test_cli_provider_resolution.py— 8/8 passed (was 1 failed before fix)