Skip to content

fix: smart vision setup that respects the user's chosen provider#1323

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-1fc28d17
Mar 14, 2026
Merged

fix: smart vision setup that respects the user's chosen provider#1323
teknium1 merged 2 commits into
mainfrom
hermes/hermes-1fc28d17

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

  • salvage the provider-aware vision setup flow from fix: smart vision setup that respects the user's chosen provider #945 onto current main
  • make the setup summary report vision availability for OpenRouter, active Nous/Codex auth, and direct OpenAI endpoints instead of hardcoding OPENROUTER_API_KEY
  • keep the OpenAI vision default explicit so auxiliary vision uses gpt-4o-mini instead of falling back to the main model slug
  • add regression coverage for the new vision prompts and summary behavior

Test plan

  • python -m pytest tests/ -n0 -q
  • python -m pytest tests/hermes_cli/test_setup.py tests/hermes_cli/test_setup_model_provider.py -n0 -q
  • python -m hermes_cli.main chat -q "Reply with OK."

The old flow blindly asked for an OpenRouter API key after ANY non-OR
provider selection, even for Nous Portal and Codex which already
support vision natively. This was confusing and annoying.

New behavior:
- OpenRouter: skip — vision uses Gemini via their OR key
- Nous Portal OAuth: skip — vision uses Gemini via Nous
- OpenAI Codex: skip — gpt-5.3-codex supports vision
- Custom endpoint (api.openai.com): show OpenAI vision model picker
  (gpt-4o, gpt-4o-mini, gpt-4.1, etc.), saves AUXILIARY_VISION_MODEL
- Custom (other) / z.ai / kimi / minimax / nous-api:
  - First checks if existing OR/Nous creds already cover vision
  - If not, offers friendly choice: OpenRouter / OpenAI / Skip
  - No more 'enter OpenRouter key' thrown in your face

Also fixes the setup summary to check actual vision availability
across all providers instead of hardcoding 'requires OPENROUTER_API_KEY'.
MoA still correctly requires OpenRouter (calls multiple frontier models).
Add regression coverage for the new provider-aware vision setup flow and make the default OpenAI choice write AUXILIARY_VISION_MODEL so auxiliary vision requests don't fall back to the main model slug.
@teknium1 teknium1 merged commit 14738e0 into main Mar 14, 2026
1 check passed
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
…1fc28d17

fix: smart vision setup that respects the user's chosen provider
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…1fc28d17

fix: smart vision setup that respects the user's chosen provider
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
…1fc28d17

fix: smart vision setup that respects the user's chosen provider
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
…1fc28d17

fix: smart vision setup that respects the user's chosen provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant