fix: smart vision setup that respects the user's chosen provider#945
Closed
teknium1 wants to merge 1 commit into
Closed
fix: smart vision setup that respects the user's chosen provider#945teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
The old flow blindly asked for an OpenRouter API key after ANY non-OR provider selection, even for Nous Portal and Codex which already support vision natively. This was confusing and annoying. New behavior: - OpenRouter: skip — vision uses Gemini via their OR key - Nous Portal OAuth: skip — vision uses Gemini via Nous - OpenAI Codex: skip — gpt-5.3-codex supports vision - Custom endpoint (api.openai.com): show OpenAI vision model picker (gpt-4o, gpt-4o-mini, gpt-4.1, etc.), saves AUXILIARY_VISION_MODEL - Custom (other) / z.ai / kimi / minimax / nous-api: - First checks if existing OR/Nous creds already cover vision - If not, offers friendly choice: OpenRouter / OpenAI / Skip - No more 'enter OpenRouter key' thrown in your face Also fixes the setup summary to check actual vision availability across all providers instead of hardcoding 'requires OPENROUTER_API_KEY'. MoA still correctly requires OpenRouter (calls multiple frontier models).
Contributor
Author
|
Merged via #1323. I cherry-picked the substantive setup wizard change onto current main, then added a small follow-up so the default OpenAI vision choice persists AUXILIARY_VISION_MODEL and added regression coverage for the new flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The setup wizard blindly asks for an OpenRouter API key after ANY non-OpenRouter provider selection — even for Nous Portal and Codex which already support vision natively. If you just chose OpenAI as your provider, getting
Enter OpenRouter API keythrown in your face is confusing and annoying.Solution
Replace the blanket OpenRouter key prompt with provider-aware vision setup:
For providers that don't support vision, the prompt is friendlier and contextual:
Also fixes the setup summary to check actual vision availability across all providers instead of hardcoding 'requires OPENROUTER_API_KEY'. MoA still correctly requires OpenRouter (calls multiple frontier models).
Changes
hermes_cli/setup.py: Replaced vision setup block + fixed summary section