fix(tui): theme-driven update-behind banner + auto-detect light terminals (#11300)#13103
Merged
Conversation
…t terminals (#11300) - branding.tsx: `color="yellow"` → `t.color.warn` so light-mode users get the burnt-orange warn instead of unreadable bright yellow on white bg. - theme.ts: replace HERMES_TUI_LIGHT regex with `detectLightMode(env)` that also sniffs `COLORFGBG` (XFCE Terminal, rxvt, Terminal.app, iTerm2). Bg slot 7 or 15 → LIGHT_THEME. Explicit HERMES_TUI_LIGHT (on *or* off) still wins. - tests: cover empty env, explicit on/off, COLORFGBG positions, and off-override.
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
…mode-11300 fix(tui): theme-driven update-behind banner + auto-detect light terminals (NousResearch#11300)
aj-nt
pushed a commit
to aj-nt/hermes-agent
that referenced
this pull request
May 1, 2026
…mode-11300 fix(tui): theme-driven update-behind banner + auto-detect light terminals (NousResearch#11300)
Luminet2023
pushed a commit
to Luminet2023/hermes-agent
that referenced
this pull request
May 1, 2026
…mode-11300 fix(tui): theme-driven update-behind banner + auto-detect light terminals (NousResearch#11300)
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…mode-11300 fix(tui): theme-driven update-behind banner + auto-detect light terminals (NousResearch#11300)
8 tasks
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…mode-11300 fix(tui): theme-driven update-behind banner + auto-detect light terminals (NousResearch#11300)
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…mode-11300 fix(tui): theme-driven update-behind banner + auto-detect light terminals (NousResearch#11300)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11300. Alt to #12487 — routes through the existing theme instead of swapping one hardcoded color for another.
Summary
branding.tsx: 4×color="yellow"→color={t.color.warn}. Now respects theme (amber#ffa726on dark, burnt-orange#E65100on light). PR fix(tui): replace unreadable yellow colors with dark goldenrod (#11300) #12487 swapped in#b8860b— better than bright yellow but still bypasses the theme and ignores the LIGHT_THEME that already landed in20eab355.theme.ts:HERMES_TUI_LIGHTregex →detectLightMode(env)that also sniffsCOLORFGBG. Bg slot 7 or 15 → LIGHT_THEME. ExplicitHERMES_TUI_LIGHT(on or off) still wins. XFCE Terminal / rxvt / Terminal.app / iTerm2 users get light mode with no config.theme.test.ts: +10 assertions covering empty env, explicit on/off, COLORFGBG positions (0;15,0;default;15,0;7,15;0,7;default;0), and off-overrides-light.Test plan
npm run type-check— cleannpx vitest run src/__tests__/theme.test.ts— 15/15npm run linton touched files — clean (pre-existing errors unrelated)COLORFGBG=0;15 hermes --tuion a real light terminal shows dark-orange "commits behind" textNotes for reviewers
If #12487 is preferred for the color-swap narrowness, this PR supersedes it: same readability win, plus the theme path and autodetect. If both land, the
color={t.color.warn}change is a clean rebase on top.