fix(tui): replace unreadable yellow colors with dark goldenrod (#11300)#12487
Closed
Sanjays2402 wants to merge 1 commit into
Closed
fix(tui): replace unreadable yellow colors with dark goldenrod (#11300)#12487Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
Fixes NousResearch#11300 — bright yellow text was unreadable on light terminal backgrounds. Replaced color="yellow" with color="#b8860b" (dark goldenrod) which is readable on both light and dark backgrounds.
4 tasks
Collaborator
|
Good catch, made it a little bit smarter here so its theme friendly #13103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11300
Bright yellow text in the TUI branding component was unreadable on white/light terminal backgrounds. Replaced all four instances of hardcoded
color="yellow"inui-tui/src/components/branding.tsxwithcolor="#b8860b"(dark goldenrod), which provides good contrast on both light and dark backgrounds.