fix(install): quote PYTHON_PATH and UV_CMD for paths with spaces on macOS (#10009)#13001
Merged
Conversation
…acOS (#10009) Cherry-picked from PR #10019 by @PStarH. On macOS, uv stores Python in ~/Library/Application Support/uv/... which contains a space. Unquoted $PYTHON_PATH and $UV_CMD caused word-splitting under set -e, silently aborting install.sh. Quotes all variable expansions in check_python(): - "$PYTHON_PATH" in command invocations - "$UV_CMD" in uv calls - Outer quotes on $(...) assignments Closes #10009
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.sh no longer crashes on macOS when uv's Python path contains spaces (~/Library/Application Support/uv/...).
Cherry-picked from PR #10019 by @PStarH onto current main.
Changes
scripts/install.sh: Quote all$PYTHON_PATHand$UV_CMDexpansions incheck_python()scripts/release.py: AUTHOR_MAP entry for @PStarHValidation
Library/Application: No such file or directorybash -n scripts/install.shpasses.Closes #10009
Supersedes #10010, #10019, #10054, #10118