fix: quote $PYTHON_PATH in install.sh to handle paths with spaces#10118
Closed
nightq wants to merge 1 commit into
Closed
fix: quote $PYTHON_PATH in install.sh to handle paths with spaces#10118nightq wants to merge 1 commit into
nightq wants to merge 1 commit into
Conversation
Fixes NousResearch#10009 Root cause: Unquoted variable expansion in check_python() causes silent failure when Python path contains spaces (e.g., ~/Library/Application Support/uv/...) Fix: Quote all $PYTHON_PATH usages inside command substitutions
1 task
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes silent installation failure on macOS when Python path contains spaces (e.g.,
~/Library/Application Support/uv/...).Root Cause
The
check_python()function inscripts/install.shuses unquoted variable expansion ($PYTHON_PATH) inside command substitutions. Withset -eenabled, paths with spaces cause the shell to split the path and attempt to execute a non-existent command, triggering silent exit.Fix
Quoted all 4 instances of
$PYTHON_PATHinside command substitutions:$PYTHON_FOUND_VERSION=$("$PYTHON_PATH" --version)Test Plan
bash install.shon macOS with Python installed via uv (path contains spaces)Closes #10009