fix(install): quote PYTHON_PATH in version checks to handle spaces on macOS#10010
Closed
haoyousun60-create wants to merge 1 commit into
Closed
Conversation
… macOS Lines with unquoted $PYTHON_PATH --version cause 'set -e' to silently abort when uv returns a path with spaces (e.g. ~/Library/Application Support/uv/...). Wrap all $PYTHON_FOUND_VERSION assignments in double quotes to prevent word splitting. Fixes: NousResearch/issues/10009
1 task
Contributor
|
Closed in favor of PR #13001 #13001 which uses @PStarH's more thorough fix (inner+outer quoting plus $UV_CMD). Thanks @haoyousun60-create! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrap all
$PYTHON_FOUND_VERSIONassignments in double quotes to prevent word splitting when the Python path contains spaces (e.g. on macOS with uv-managed Python in~/Library/Application Support/uv/...).Root Cause
Lines 258, 267, 278, 287 used unquoted
$PYTHON_PATH --version:When
$PYTHON_PATHcontains a space, bash word-splits it andset -esilently aborts the install script.Fix
Testing
Closes #10009