fix(batch_runner): mark discarded no-reasoning prompts as completed (#9950)#12997
Merged
Conversation
…9950) Cherry-picked from PR #10005 by @houziershi. Discarded prompts (has_any_reasoning=False) were skipped by `continue` before being added to completed_in_batch. On --resume they were retried forever. Now they are added to completed_in_batch before the continue. - Added AUTHOR_MAP entry for @houziershi Closes #9950
This was referenced Apr 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discarded no-reasoning prompts are now marked as completed so
--resumedoesn't retry them forever.Cherry-picked from PR #10005 by @houziershi onto current main.
Changes
batch_runner.py: Addcompleted_in_batch.append(prompt_index)beforecontinuein the no-reasoning discard branchtests/test_batch_runner_checkpoint.py: Regression test verifying discarded prompts appear incompleted_promptsscripts/release.py: AUTHOR_MAP entry for @houziershiValidation
completed_prompts--resumebehavior13/13 batch_runner checkpoint tests pass.
Closes #9950
Supersedes #9968, #10005, #9993, #10042