fix: mark discarded no-reasoning prompts as completed in batch_runner#10042
Closed
nightq wants to merge 3 commits into
Closed
fix: mark discarded no-reasoning prompts as completed in batch_runner#10042nightq wants to merge 3 commits into
nightq wants to merge 3 commits into
Conversation
added 3 commits
April 15, 2026 11:41
Fixes NousResearch#9999 Root cause: _sanitize_api_messages compared raw tool_call_id strings without stripping whitespace, causing valid tool results to be treated as orphaned when IDs had leading/trailing spaces. Fix: strip whitespace in _get_tool_call_id_static and when collecting result_call_ids from tool messages.
Fixes NousResearch#9980 Root cause: _send_raw_message hardcoded 'chat_id' as receive_id_type, causing [230001] invalid receive_id errors when sending to user open_ids (prefix 'ou_') or union_ids (prefix 'on_'). Fix: Add _detect_receive_id_type() that checks ID prefix (oc_→chat_id, ou_→open_id, on_→union_id) and use it in _send_raw_message.
Fixes NousResearch#9950 Root cause: Prompts discarded for having no reasoning were not added to completed_in_batch, causing --resume to retry them indefinitely. Fix: Append prompt_index to completed_in_batch before continuing past the discard branch.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes batch_runner
--resumeinfinitely retrying prompts that were intentionally discarded for having no reasoning.Root Cause
_process_batch_worker()discards prompts withhas_any_reasoning == Falseby incrementingdiscarded_no_reasoningandcontinue-ing. However, these prompt indices were never added tocompleted_in_batch, so the checkpoint didn't record them as dispositioned. On--resume, they were treated as unfinished work and retried indefinitely.Fix
Append the prompt index to
completed_in_batchbefore thecontinuein the discard branch, so the checkpoint reflects the terminal outcome.Test Plan
Closes #9950