fix(batch_runner): add discarded prompts to completed set on resume#9993
Closed
zhouhe-xydt wants to merge 1 commit into
Closed
fix(batch_runner): add discarded prompts to completed set on resume#9993zhouhe-xydt wants to merge 1 commit into
zhouhe-xydt wants to merge 1 commit into
Conversation
When a prompt was discarded due to has_any_reasoning=False, the prompt index was never added to completed_in_batch. This caused --resume to retry the same prompt indefinitely. Fixes NousResearch#9950
Contributor
|
Closed in favor of PR #12997 #12997 which fixes the same issue. Thanks @zhouhe-xydt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where prompts discarded for having no reasoning (
has_any_reasoning=False) were not added tocompleted_in_batch, causing--resumeto retry them indefinitely.What changed
In
_process_batch_worker(), when a prompt is discarded due to zero reasoning across all turns, we now append itsprompt_indextocompleted_in_batchbefore continuing. This ensures the checkpoint records the prompt as dispositioned andresumewill not re-run it.Related issue
Fixes #9950
Testing
py_compilecompleted_promptsChecklist