Add support to resolve bindings to built-in functions, types and variables by ggiraldez · Pull Request #1101 · NomicFoundation/slang

ggiraldez · 2024-09-20T03:47:03Z

This PR adds the infrastructure to the Bindings implementation to be able to:

define built-in functions, types and global variables, optionally specifying version ranges for those
generate an internal built-ins file that can be consumed by the implementation when creating a Bindings object for a specific language version
resolve references to built-ins in Solidity by adding some rules to the graph builder file to connect the built-ins parsed file and make all definitions there available to all other ingested source units

So far, this contains just a few built-ins to test the infrastructure and verify that all functions, types and variables can be resolved.

…truction

…tency

changeset-bot · 2024-09-20T03:47:06Z

⚠️ No Changeset found

Latest commit: 74748ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

... and to silence clippy :)

crates/codegen/language/definition/src/compiler/analysis/mod.rs

crates/codegen/language/definition/src/model/manifest.rs

crates/solidity/testing/snapshots/bindings_output/modifiers/simple/generated/0.5.0-success.txt

...s/solidity/testing/snapshots/bindings_output/modifiers/with_args/generated/0.5.0-success.txt

crates/solidity/outputs/cargo/slang_solidity/src/generated/bindings/generated/built_ins.rs

crates/solidity/inputs/language/bindings/rules.msgb

crates/solidity/testing/perf/benches/iai/main.rs

...s/solidity/testing/snapshots/bindings_output/built_ins/functions/generated/0.8.4-success.txt

crates/testlang/outputs/npm/package/build.rs

… strings Strings for the `PathResolver` represent user paths, which is the only context in which import path resolution makes sense.

OmarTawfik

Resolved the rest of the threads. Thanks!

crates/metaslang/bindings/src/lib.rs

minor improvement to the codegen backend based on earlier discussions in NomicFoundation#1101

minor improvement to the codegen backend based on earlier changes in NomicFoundation#1101 and NomicFoundation#1120 - build npm packages in parallel - rename `BuiltInLabel` to `PredefinedLabel` to disambiguate from the newly introduced built-ins in bindings. - Fix a bug where breaking versions in built-ins were not considered in other parts of codegen. - rename `wasm32-wasi` to `wasm32-wasip1`, as it is already deprecated in nightly.

minor improvement to the codegen backend based on earlier changes in NomicFoundation#1101 and NomicFoundation#1120 - build npm packages in parallel - rename `BuiltInLabel` to `PredefinedLabel` to disambiguate from the newly introduced built-ins in bindings. - rename `wasm32-wasi` to `wasm32-wasip1`, as it is already deprecated in nightly.

minor improvements to the codegen backend based on earlier changes in #1101 and #1120 - build npm packages in parallel - rename `BuiltInLabel` to `PredefinedLabel` to disambiguate from the newly introduced built-ins in bindings. - rename `wasm32-wasi` to `wasm32-wasip1`, as it is already deprecated in nightly.

ggiraldez added 9 commits September 13, 2024 18:11

First cut at implementing support for bindings built-in identifiers

dd6e148

Move builtins content to the language definition and load during cons…

8a7ef47

…truction

Move built-ins rendering specific code to the input language

9a12700

Make generated built-ins source dependant on the language version

bf9de78

Separate built-ins parsing test

ba6c84d

Allow filtering of fields in built-in type per version

81b9c95

Check built-ins in language definitions for version enablement consis…

fcc371e

…tency

Make built-in types, functions and variables visible

ebd47c4

Simplify built-in parameter and field definitions

486aebb

ggiraldez added 5 commits September 19, 2024 23:57

Output a built-in marker when found in ambiguous definitions

5939f3b

Rename builtin -> built-in (and similar identifiers)

bef4458

Refactor: split apart render_bindings for readability

c6275db

... and to silence clippy :)

Externalize built-ins file path from the graph building rules file

3757c60

Use a Vec<String> for built-in parameters definition

d6fe128

ggiraldez marked this pull request as ready for review September 20, 2024 19:33

ggiraldez requested a review from a team as a code owner September 20, 2024 19:33

ggiraldez mentioned this pull request Sep 20, 2024

Implement Solidity binding rules #1077

Closed

33 tasks

Merge remote-tracking branch 'upstream/main' into builtin-bindings

23ecf01