Merged
Conversation
|
7304707 to
b4b1879
Compare
ggiraldez
approved these changes
Nov 19, 2024
Contributor
ggiraldez
left a comment
There was a problem hiding this comment.
One minor non-blocking nit, but otherwise LGTM!
| @@ -15,7 +15,7 @@ pub struct KindsModel { | |||
| /// Defines `EdgeLabel` enum variants. | |||
| labels: BTreeSet<Identifier>, | |||
| /// Built-in labels for edges. | |||
Contributor
There was a problem hiding this comment.
nit: Update the comment as well?
minor improvement to the codegen backend based on earlier changes in NomicFoundation#1101 and NomicFoundation#1120 - build npm packages in parallel - rename `BuiltInLabel` to `PredefinedLabel` to disambiguate from the newly introduced built-ins in bindings. - rename `wasm32-wasi` to `wasm32-wasip1`, as it is already deprecated in nightly.
b4b1879 to
8eed45c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor improvements to the codegen backend based on earlier changes in #1101 and #1120
BuiltInLabeltoPredefinedLabelto disambiguate from the newly introduced built-ins in bindings.wasm32-wasitowasm32-wasip1, as it is already deprecated in nightly.