Skip to content

Port tests to Python#72833

Merged
domenkozar merged 7 commits intoNixOS:masterfrom
marijanp:port-tests-python
Nov 6, 2019
Merged

Port tests to Python#72833
domenkozar merged 7 commits intoNixOS:masterfrom
marijanp:port-tests-python

Conversation

@marijanp
Copy link
Copy Markdown
Contributor

@marijanp marijanp commented Nov 5, 2019

Motivation for this change

Processing the task list in issue #72828.

Now that PR #71684 (nixos: add python testing support) by @tfc got merged, I would like to port some of the tests to Python.

Things done

Ported several tests to Python, which also conform the Black code style.
Tests have been run and all of them succeed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc @flokli

@marijanp
Copy link
Copy Markdown
Contributor Author

marijanp commented Nov 5, 2019

This PR can be marked as a WIP as I will continue port more of the tasks listed in #72828 the next few days. @flokli @tfc

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 5, 2019
@tfc tfc mentioned this pull request Nov 5, 2019
Closed
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Nov 5, 2019

Babeld got merged in a smaller PR #72834.
Perhaps it would be better to merge this now and in smaller pieces.

@marijanp
Copy link
Copy Markdown
Contributor Author

marijanp commented Nov 6, 2019

@worldofpeace I've removed my changes for babeld

@domenkozar domenkozar merged commit f103882 into NixOS:master Nov 6, 2019
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Nov 6, 2019

Thanks @marijanp ✨

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
@domenkozar @dtzWill
Merge pull request NixOS#72833 from marijanp/port-tests-python
6105caa 
Port tests to Python

(cherry picked from commit f103882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marijanp @worldofpeace @domenkozar