Skip to content

nixos/tests: migrate my tests to python#72834

Merged
worldofpeace merged 3 commits intoNixOS:masterfrom
mweinelt:pr/tests/migrate-python
Nov 5, 2019
Merged

nixos/tests: migrate my tests to python#72834
worldofpeace merged 3 commits intoNixOS:masterfrom
mweinelt:pr/tests/migrate-python

Conversation

@mweinelt
Copy link
Copy Markdown
Member

@mweinelt mweinelt commented Nov 5, 2019 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @marijanp

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 5, 2019
@mweinelt mweinelt force-pushed the pr/tests/migrate-python branch from 7703770 to 282af5c Compare November 5, 2019 15:18
@mweinelt mweinelt force-pushed the pr/tests/migrate-python branch from 282af5c to 014970b Compare November 5, 2019 15:19
@tfc tfc mentioned this pull request Nov 5, 2019
Closed
worldofpeace
worldofpeace approved these changes Nov 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran both tests. Ports looked fine.

@worldofpeace worldofpeace merged commit e73c93d into NixOS:master Nov 5, 2019
@worldofpeace worldofpeace mentioned this pull request Nov 5, 2019
Merged
10 tasks
@mweinelt mweinelt deleted the pr/tests/migrate-python branch November 5, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

+1 more reviewer

@worldofpeace worldofpeace worldofpeace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mweinelt @tfc @worldofpeace