Skip to content

nixos/xserver: drop intel from videoDrivers#55583

Merged
7c6f434c merged 4 commits intomasterfrom
drop-intel-video-driver
Feb 21, 2019
Merged

nixos/xserver: drop intel from videoDrivers#55583
7c6f434c merged 4 commits intomasterfrom
drop-intel-video-driver

Conversation

@7c6f434c
Copy link
Copy Markdown
Member

@7c6f434c 7c6f434c commented Feb 11, 2019

Motivation for this change

#55520 — the old intel driver might create problems in multi-GPU multi-output situations (and maybe in some other situations requiring precise use of modern features).

Things done

I have not tested it properly as I don't run NixOS mainline. (I did switch to modesetting after X.org update in Nixpkgs).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c 7c6f434c requested a review from infinisil as a code owner February 11, 2019 21:44
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 11, 2019
@7c6f434c
Copy link
Copy Markdown
Member Author

7c6f434c commented Feb 11, 2019

Good question. No idea, actually. Is there any GPGPU framework that works on X/Linux without being tied to a bitrotten video driver not fully supporting modern XRandR, I wonder.

@flokli
Copy link
Copy Markdown
Member

flokli commented Feb 11, 2019

cc @oxij

@oxij
Copy link
Copy Markdown
Member

oxij commented Feb 13, 2019 via email

@7c6f434c
Copy link
Copy Markdown
Member Author

7c6f434c commented Feb 13, 2019

Hm. It looks like Intel VA-API somewhat supports Wayland, I wonder if that means they are also fine with modesetting intel/libva#53. And Beignet claims to work without X11 if desired.

If you have a Nix expression that uses OpenCL on Intel around — I run a Intel+Nvidia i965+nouveau modesetting system, so I can check if that code works.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Feb 13, 2019

People doing GPGPU will probably know enough to add videoDriver = "intel"; into their configs.

@7c6f434c
Copy link
Copy Markdown
Member Author

7c6f434c commented Feb 13, 2019

@volth thanks. It seems to look for OpenCL configuration in a place defined relative to libGL. Adding beignet to the packages for opengl-driver buildEnv seems to help.

Using default runtime: v4.0.30319
Id:0 Name:Intel(R) HD Graphics IvyBridge M GT2
    PreferredGroupSizeMultiple:16 ComputeUnits:16 ClockFrequency:1000
    MaxConstantBufferSize:134217728 MaxConstantArgs:8 MaxMemAllocSize:1610612736

@vcunat by now I mostly collect information for release notes.

@7c6f434c 7c6f434c merged commit 95039d0 into master Feb 21, 2019
@vcunat vcunat deleted the drop-intel-video-driver branch February 21, 2019 11:51
@obadz obadz mentioned this pull request Feb 23, 2019
Closed
@fgaz fgaz mentioned this pull request Apr 17, 2019
Closed
@gloaming
Copy link
Copy Markdown
Contributor

gloaming commented Jun 6, 2019

cl_get_gt_device(): error, unknown device: 3e94

@volth Coffee Lake (but not including CL-R) is supported only in their HEAD, see intel/beignet@7e181af

Should we move nixpkgs ahead of the release version? It's not clear if they will make another, since it's more or less dead.

@gloaming
Copy link
Copy Markdown
Contributor

gloaming commented Jun 17, 2019

@7c6f434c I'm not sure that there is any relationship between the (Intel) display and OCL drivers - I didn't see any mention of a GPU driver requirement on Intel's website, nor in the READMEs in their github repos.

I tested disabling modesetting and using the fbdev and vesa drivers on my machine, in turn, and waifu2x-converter-cpp --force-OpenCL still ran fine with both, even though the vesa driver doesn't actually work for me. This is using intel-ocl though, since I'm on CL-R.

@volth could you test the same with beignet?

kennyballou added a commit to kennyballou/cfg.nix that referenced this pull request Jan 21, 2021
@kennyballou
x11: intel: prefer modesetting driver
dc9703e 
Following the discussion from nixpkgs[0], Iris Xe graphics performance
dramatically better using the modesetting driver than the intel driver.

[0]: NixOS/nixpkgs#55583

Signed-off-by: Kenny Ballou <kballou@devnulllabs.io>
@7c6f434c 7c6f434c mentioned this pull request Aug 10, 2021
Open
@vlinkz vlinkz mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@7c6f434c @flokli @oxij @vcunat @gloaming @GrahamcOfBorg