Marry meta.broken with meta.problems#494416
Merged
ConnorBaker merged 2 commits intoNixOS:masterfrom Mar 24, 2026
Merged
Conversation
3 tasks
ConnorBaker
reviewed
Feb 26, 2026
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Mar 2, 2026
This was an oversight in NixOS#478539 that became apparent in NixOS#494416: If there's a failing problem in Nixpkgs packages, CI will call handleEvalIssue on it, but the problem error was missing a `.reason`. Though even if it did have a reason, we need to do more to make sure we don't break any code that uses it, so the new code uses the problem kind as the reason, which happens to match with the reason for all expected problem kinds.
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Mar 2, 2026
This was an oversight in NixOS#478539 that became apparent in NixOS#494416: If there's a failing problem in Nixpkgs packages, CI will call handleEvalIssue on it, but the problem error was missing a `.reason`. Though even if it did have a reason, we need to do more to make sure we don't break any code that uses it, so the new code uses the problem kind as the reason, which happens to match with the reason for all expected problem kinds.
1 task
ConnorBaker
approved these changes
Mar 7, 2026
Contributor
|
@infinisil I'm happy to merge this if you feel it's ready! |
c574234 to
48422de
Compare
Member
Author
|
@ConnorBaker Ready now! Rebased on top of #496156 now :) |
ambroisie
reviewed
Mar 25, 2026
Comment on lines
+44
to
50
| - For permanently allowing broken packages with a specific name to be built, you may add a corresponding `problems.handlers` to your user's configuration file, for example: | ||
|
|
||
| ```nix | ||
| { | ||
| allowBrokenPredicate = pkg: builtins.elem (pkgs.lib.getName pkg) [ "hello" ]; | ||
| problems.handlers.hello.broken = "warn"; # or "ignore" | ||
| } | ||
| ``` |
Contributor
There was a problem hiding this comment.
This code block doesn't match the description above.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta.brokenusemeta.problems.brokenunderneath.config.allowBrokenPredicatein favor ofconfig.problem.handlersFollow-up on #478539
Things done
meta.brokenconfig.allowBrokenPredicatethat only triggers aftermeta.problemsis supported in all stable releases