stdenv: Fix handleEvalIssue for error problems#496156
Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom Mar 11, 2026
Merged
stdenv: Fix handleEvalIssue for error problems#496156ConnorBaker merged 1 commit intoNixOS:masterfrom
ConnorBaker merged 1 commit intoNixOS:masterfrom
Conversation
This was an oversight in NixOS#478539 that became apparent in NixOS#494416: If there's a failing problem in Nixpkgs packages, CI will call handleEvalIssue on it, but the problem error was missing a `.reason`. Though even if it did have a reason, we need to do more to make sure we don't break any code that uses it, so the new code uses the problem kind as the reason, which happens to match with the reason for all expected problem kinds.
4 tasks
ConnorBaker
approved these changes
Mar 7, 2026
Contributor
|
@infinisil happy to merge if you want |
Member
Author
|
@ConnorBaker That would be great :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an oversight in #478539 that became apparent in #494416:
If there's a failing problem in Nixpkgs packages, CI will call handleEvalIssue on it, but the problem error was missing a
.reason.Though even if it did have a reason, we need to do more to make sure we don't break any code that uses it, so the new code uses the problem kind as the reason, which happens to match with the reason for all expected problem kinds.
Things done