Skip to content

ncompress: fix build against gcc 15#442638

Closed
Sigmanificient wants to merge 1 commit into
NixOS:stagingfrom
Sigmanificient:ncompress
Closed

ncompress: fix build against gcc 15#442638
Sigmanificient wants to merge 1 commit into
NixOS:stagingfrom
Sigmanificient:ncompress

Conversation

@Sigmanificient

@Sigmanificient Sigmanificient commented Sep 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Testing with

nix-build -E '
  { p }: let
    pkgs = (import ./. {});
  in pkgs.${p}.override { stdenv = pkgs.gcc15Stdenv; }
' --argstr p "ncompress"

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Sep 13, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 13, 2025
@Sigmanificient Sigmanificient changed the base branch from master to staging September 13, 2025 14:49
@nixpkgs-ci nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 13, 2025
@nixpkgs-ci nixpkgs-ci Bot closed this Sep 13, 2025
@nixpkgs-ci nixpkgs-ci Bot reopened this Sep 13, 2025
@yuyuyureka yuyuyureka mentioned this pull request Sep 18, 2025
Merged
13 tasks
@Aleksanaa Aleksanaa requested a review from vcunat September 28, 2025 12:46
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 28, 2025
@fabianhjr fabianhjr added the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Nov 7, 2025
marcin-serwin
marcin-serwin requested changes Nov 15, 2025
View reviewed changes

@marcin-serwin marcin-serwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling functions via a differently typed pointer is technically UB though it will likely work correctly. IMO a better fix is to apply vapier/ncompress#40.

@fabianhjr fabianhjr removed the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Nov 24, 2025
@SuperSandro2000

SuperSandro2000 commented Nov 24, 2025

Copy link
Copy Markdown
Member

#442637 does that, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcin-serwin marcin-serwin marcin-serwin requested changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sigmanificient @SuperSandro2000 @marcin-serwin @fabianhjr