Skip to content

ncompress: fix build against gcc15 #442637

Merged
fabianhjr merged 2 commits into
NixOS:stagingfrom
SuperSandro2000:gcc15-ncompress
Nov 24, 2025
Merged

ncompress: fix build against gcc15 #442637
fabianhjr merged 2 commits into
NixOS:stagingfrom
SuperSandro2000:gcc15-ncompress

Conversation

@SuperSandro2000

@SuperSandro2000 SuperSandro2000 commented Sep 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 changed the title Gcc15 ncompress ncompress: fix build against gcc15 Sep 13, 2025
@SuperSandro2000 SuperSandro2000 mentioned this pull request Sep 13, 2025
Merged
13 tasks
@Sigmanificient

Sigmanificient commented Sep 13, 2025

Copy link
Copy Markdown
Member

Oh well i just opened #442638

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 13, 2025
@SuperSandro2000

SuperSandro2000 commented Sep 13, 2025

Copy link
Copy Markdown
Member Author

That might be better than this one because it has more potential for braking changes.

@fabianhjr

fabianhjr commented Nov 7, 2025

Copy link
Copy Markdown
Member

I'm inclined for this over the other PR, will wait for branch-off regradless

@fabianhjr fabianhjr added the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Nov 7, 2025
@fabianhjr fabianhjr removed the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Nov 24, 2025
@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 24, 2025
Closed
13 tasks
@SuperSandro2000

SuperSandro2000 commented Nov 24, 2025

Copy link
Copy Markdown
Member Author

So we merge this now?

@fabianhjr fabianhjr added this pull request to the merge queue Nov 24, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 24, 2025
Merged via the queue into NixOS:staging with commit 9d12dde Nov 24, 2025
42 checks passed
@SuperSandro2000 SuperSandro2000 deleted the gcc15-ncompress branch November 25, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @Sigmanificient @fabianhjr