compress.c: fix -std=c23 build failure (signal handler protos)#40
Open
trofi wants to merge 1 commit into
Open
Conversation
gcc-15 switched to -std=c23 by default:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212
As a result `ncompress` fails the build as:
compress.c: In function 'main':
compress.c:382:40: error:
passing argument 2 of 'signal' from incompatible pointer type [-Wincompatible-pointer-types]
382 | signal(SIGINT, (SIG_TYPE)abort_compress);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| |
| void (*)(void)
In file included from compress.c:30:
...-glibc-2.40-36-dev/include/signal.h:88:57: note:
expected '__sighandler_t' {aka 'void (*)(int)'} but argument is of type 'void (*)(void)'
88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
| ~~~~~~~~~~~~~~~^~~~~~~~~
The change removes type casts around function prototypes and define
signal handler as `void(*)(int)`.
|
IMO it would be good to merge this PR and release new version. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc-15 switched to -std=c23 by default:
As a result
ncompressfails the build as:The change removes type casts around function prototypes and define signal handler as
void(*)(int).