Skip to content

rocmPackages: 6.3.3 -> 6.4.3#427944

Merged
emilazy merged 11 commits intoNixOS:stagingfrom
LunNova:lunnova/rocm-6.4.x
Sep 15, 2025
Merged

rocmPackages: 6.3.3 -> 6.4.3#427944
emilazy merged 11 commits intoNixOS:stagingfrom
LunNova:lunnova/rocm-6.4.x

Conversation

@LunNova
Copy link
Copy Markdown
Member

@LunNova LunNova commented Jul 24, 2025

Fixes #412640
Fixes #418825
Fixes #434280

TODO

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LunNova LunNova changed the title WIP 6.4.1 bump rocmPackages: 6.3.3 -> 6.4.x Jul 24, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. labels Jul 24, 2025
@LunNova LunNova force-pushed the lunnova/rocm-6.4.x branch from e8872b0 to f034276 Compare July 24, 2025 02:30
@LunNova

This comment was marked as outdated.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 24, 2025
@LunNova LunNova force-pushed the lunnova/rocm-6.4.x branch from ed91505 to 8d8c252 Compare August 6, 2025 00:16
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 6, 2025
@LunNova LunNova force-pushed the lunnova/rocm-6.4.x branch from 8d8c252 to 11a7af6 Compare August 6, 2025 01:22
@LunNova LunNova changed the title rocmPackages: 6.3.3 -> 6.4.x rocmPackages: 6.3.3 -> 6.4.2 Aug 6, 2025
@LunNova LunNova force-pushed the lunnova/rocm-6.4.x branch 4 times, most recently from 29e7d0c to 2758d52 Compare August 7, 2025 05:15
@LunNova

This comment was marked as outdated.

@LunNova LunNova force-pushed the lunnova/rocm-6.4.x branch 3 times, most recently from 8089e29 to 87e341b Compare August 7, 2025 16:17
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 7, 2025
@LunNova LunNova force-pushed the lunnova/rocm-6.4.x branch 3 times, most recently from 6715162 to 8b7c3c1 Compare August 7, 2025 17:00
@nixpkgs-ci nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 7, 2025
@LunNova LunNova force-pushed the lunnova/rocm-6.4.x branch from 8b7c3c1 to 251034d Compare August 8, 2025 00:26
@LunNova

This comment was marked as outdated.

@mrdev023
Copy link
Copy Markdown
Contributor

@LunNova What's the remaining works need on this Merge request ?

New version is available: https://github.com/ROCm/ROCm/releases/tag/rocm-6.4.3

@LunNova
Copy link
Copy Markdown
Member Author

LunNova commented Aug 29, 2025

The PR might be fine in its current state, I haven't had time to do proper testing since applying @GZGavinZhao's newest iteration of the isa compat patches.

Have been helping with #431973 this week.

@mrdev023
Copy link
Copy Markdown
Contributor

The

Okay thx for you reply ^^ nice works !
I'm waiting for my RX 9070XT ^^

@LunNova

This comment was marked as outdated.

@GZGavinZhao
Copy link
Copy Markdown
Contributor

GZGavinZhao commented Sep 3, 2025

I'm packaging 6.4.3 for Solus and I've found it is so similar to 6.4.2 that updating should be as simple as updating the source version and hash, so I'm not too worried about this PR taking a bit more time to merge.

@JohnRTitor
Copy link
Copy Markdown
Member

Current status: waiting for #438399, #438685 and #439056 to get merged first, with intent to rebase on top and redo a full review run and testing.

@LunNova is this still blocked?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hash did not change?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD doesn't update everything with every version, and the versions listed there are not the actual module versions but the associated rocm versiom. You can see the real ones here, e.g. rocFFT moved from 1.0.31 to 1.0.32 between rocm 6.3 and 6.4, but stayed at 1.0.32 from rocm 6.4.2 to 6.4.3.

Not sure whether that's actually the best way to go about things, while it unifies the absolute mess that those individual module versions are it also (corrects me if I'm wrong) changes nar hashes without any good reason, also, it differs from upstream.

Copy link
Copy Markdown
Member Author

@LunNova LunNova Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiprpp tags:
image

Yeah it's a bit awkward that this wastes store space for the source archives. no it doesn't, FODs and name is source.

AMD's been publishing the entire package set by ROCm version for a while now, many packages within it don't even have their own versioning scheme.

Most of the rebuilding in rocmPackages can't be avoided by using a separate version for individual packages because the version number set in rocm-core and clr gets bumped and everything has that as an input.

@LunNova
Copy link
Copy Markdown
Member Author

LunNova commented Sep 8, 2025

Current status: waiting for #438399, #438685 and #439056 to get merged first, with intent to rebase on top and redo a full review run and testing.

@LunNova is this still blocked?

They're merged, I've rebased, still building and testing before marking ready.

@LunNova

This comment was marked as outdated.

@LunNova

This comment was marked as resolved.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to avoid this massive reindent

Comment on lines 45 to 47
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t need to inherit it if it’s in the scope. (Applies to a bunch of stuff in this file.)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this actually changes the stdenv because this is inheriting the original normal stdenv from pkgs from outside the package set. I need to do some renaming.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed but it's still not very clear.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an error for us to build 1012 by default in previous versions, our ISA compat patches allow 1010 to load for 1012 so this just wasted resources.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilazy sadly migraphx still needs a patch. going to try to upstream this.

@LunNova
Copy link
Copy Markdown
Member Author

LunNova commented Sep 15, 2025

llama-cpp failure to investigate:

In file included from /build/source/ggml/src/ggml-cuda/fattn-tile.cu:1:
/build/source/ggml/src/ggml-cuda/common.cuh:559:18: error: instruction not supported on this GPU
  559 |     asm volatile("v_dot2_f32_f16 %0, %1, %2, %0" : "+v"(acc) : "v"(v), "v"(u));
      |                  ^
<inline asm>:1:2: note: instantiated into assembly here
    1 |         v_dot2_f32_f16 v8, v103, v99, v8

unsupported insn in a very recently added llama-cpp feature ggml-org/llama.cpp#15884

@LunNova
Copy link
Copy Markdown
Member Author

LunNova commented Sep 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 427944 --checkout commit --additional-package rocmPackages.gfx906.rocm-tests.passthru.tests.torch --additional-package rocmPackages.gfx1100.rocm-tests.passthru.tests.torch
Commit: d844a2f11124be2a736e9ac3eb6fcefefd8012bd


x86_64-linux

❌ 1 package failed to build:
  • llama-cpp-rocm
✅ 137 packages built:
  • adaptivecpp
  • adaptivecppWithCuda
  • adaptivecppWithRocm
  • blender-hip
  • btop-rocm
  • magma (magma-hip)
  • magma-cuda-static
  • magma-cuda-static.test
  • magma.test (magma-hip.test)
  • ollama-rocm
  • opensplatWithCuda
  • python312Packages.torchWithCuda
  • python312Packages.torchWithCuda.cxxdev
  • python312Packages.torchWithCuda.dev
  • python312Packages.torchWithCuda.dist
  • python312Packages.torchWithCuda.lib
  • python312Packages.torchWithRocm
  • python312Packages.torchWithRocm.cxxdev
  • python312Packages.torchWithRocm.dev
  • python312Packages.torchWithRocm.dist
  • python312Packages.torchWithRocm.lib
  • python313Packages.torchWithCuda
  • python313Packages.torchWithCuda.cxxdev
  • python313Packages.torchWithCuda.dev
  • python313Packages.torchWithCuda.dist
  • python313Packages.torchWithCuda.lib
  • python313Packages.torchWithRocm
  • python313Packages.torchWithRocm.cxxdev
  • python313Packages.torchWithRocm.dev
  • python313Packages.torchWithRocm.dist
  • python313Packages.torchWithRocm.lib
  • rocmPackages.amdsmi (rocmPackages_6.amdsmi)
  • rocmPackages.aotriton (rocmPackages_6.aotriton)
  • rocmPackages.aotriton.debug (rocmPackages_6.aotriton.debug)
  • rocmPackages.aqlprofile (rocmPackages_6.aqlprofile)
  • rocmPackages.ck4inductor (rocmPackages_6.ck4inductor)
  • rocmPackages.ck4inductor.dist (rocmPackages_6.ck4inductor.dist)
  • rocmPackages.clang (rocmPackages.llvm.clang, rocmPackages.llvm.rocmcxx, rocmPackages_6.clang, rocmPackages_6.llvm.clang, rocmPackages_6.llvm.rocmcxx)
  • rocmPackages.clr (rocmPackages_6.clr)
  • rocmPackages.clr.debug (rocmPackages_6.clr.debug)
  • rocmPackages.clr.icd (rocmPackages_6.clr.icd)
  • rocmPackages.composable_kernel (rocmPackages_6.composable_kernel)
  • rocmPackages.gfx1100.rocm-tests.passthru.tests.torch
  • rocmPackages.gfx1100.rocm-tests.passthru.tests.torch.cxxdev
  • rocmPackages.gfx1100.rocm-tests.passthru.tests.torch.dev
  • rocmPackages.gfx1100.rocm-tests.passthru.tests.torch.dist
  • rocmPackages.gfx1100.rocm-tests.passthru.tests.torch.lib
  • rocmPackages.gfx906.rocm-tests.passthru.tests.torch
  • rocmPackages.gfx906.rocm-tests.passthru.tests.torch.cxxdev
  • rocmPackages.gfx906.rocm-tests.passthru.tests.torch.dev
  • rocmPackages.gfx906.rocm-tests.passthru.tests.torch.dist
  • rocmPackages.gfx906.rocm-tests.passthru.tests.torch.lib
  • rocmPackages.half (rocmPackages_6.half)
  • rocmPackages.hip-common (rocmPackages_6.hip-common)
  • rocmPackages.hipblas (rocmPackages_6.hipblas)
  • rocmPackages.hipblas-common (rocmPackages_6.hipblas-common)
  • rocmPackages.hipblaslt (rocmPackages_6.hipblaslt)
  • rocmPackages.hipblaslt.benchmark (rocmPackages_6.hipblaslt.benchmark)
  • rocmPackages.hipcc (rocmPackages_6.hipcc)
  • rocmPackages.hipcub (rocmPackages_6.hipcub)
  • rocmPackages.hipfft (rocmPackages_6.hipfft)
  • rocmPackages.hipfort (rocmPackages_6.hipfort)
  • rocmPackages.hipify (rocmPackages_6.hipify)
  • rocmPackages.hiprand (rocmPackages_6.hiprand)
  • rocmPackages.hiprt (rocmPackages_6.hiprt)
  • rocmPackages.hipsolver (rocmPackages_6.hipsolver)
  • rocmPackages.hipsparse (rocmPackages_6.hipsparse)
  • rocmPackages.hsakmt (rocmPackages.rocm-runtime, rocmPackages_6.hsakmt, rocmPackages_6.rocm-runtime)
  • rocmPackages.hsakmt.debug (rocmPackages.rocm-runtime.debug, rocmPackages_6.hsakmt.debug, rocmPackages_6.rocm-runtime.debug)
  • rocmPackages.llvm.bintools (rocmPackages_6.llvm.bintools)
  • rocmPackages.llvm.clang-tools (rocmPackages_6.llvm.clang-tools)
  • rocmPackages.llvm.clang-unwrapped (rocmPackages_6.llvm.clang-unwrapped)
  • rocmPackages.llvm.clang-unwrapped.debug (rocmPackages_6.llvm.clang-unwrapped.debug)
  • rocmPackages.llvm.clang-unwrapped.dev (rocmPackages_6.llvm.clang-unwrapped.dev)
  • rocmPackages.llvm.clang-unwrapped.lib (rocmPackages_6.llvm.clang-unwrapped.lib)
  • rocmPackages.llvm.clang-unwrapped.python (rocmPackages_6.llvm.clang-unwrapped.python)
  • rocmPackages.llvm.compiler-rt (rocmPackages.llvm.compiler-rt-libc, rocmPackages_6.llvm.compiler-rt, rocmPackages_6.llvm.compiler-rt-libc)
  • rocmPackages.llvm.compiler-rt.dev (rocmPackages.llvm.compiler-rt-libc.dev, rocmPackages_6.llvm.compiler-rt-libc.dev, rocmPackages_6.llvm.compiler-rt.dev)
  • rocmPackages.llvm.libcxx (rocmPackages_6.llvm.libcxx)
  • rocmPackages.llvm.libcxx.dev (rocmPackages_6.llvm.libcxx.dev)
  • rocmPackages.llvm.libunwind (rocmPackages_6.llvm.libunwind)
  • rocmPackages.llvm.libunwind.dev (rocmPackages_6.llvm.libunwind.dev)
  • rocmPackages.llvm.lld (rocmPackages_6.llvm.lld)
  • rocmPackages.llvm.lld.dev (rocmPackages_6.llvm.lld.dev)
  • rocmPackages.llvm.lld.lib (rocmPackages_6.llvm.lld.lib)
  • rocmPackages.llvm.llvm (rocmPackages_6.llvm.llvm)
  • rocmPackages.llvm.llvm.dev (rocmPackages_6.llvm.llvm.dev)
  • rocmPackages.llvm.llvm.lib (rocmPackages_6.llvm.llvm.lib)
  • rocmPackages.llvm.llvm.python (rocmPackages_6.llvm.llvm.python)
  • rocmPackages.openmp (rocmPackages.llvm.openmp, rocmPackages_6.llvm.openmp, rocmPackages_6.openmp)
  • rocmPackages.openmp.dev (rocmPackages.llvm.openmp.dev, rocmPackages_6.llvm.openmp.dev, rocmPackages_6.openmp.dev)
  • rocmPackages.rocm-merged-llvm (rocmPackages.llvm.rocm-merged-llvm, rocmPackages_6.llvm.rocm-merged-llvm, rocmPackages_6.rocm-merged-llvm)
  • rocmPackages.stdenv (rocmPackages.rocmClangStdenv, rocmPackages_6.llvm.rocmClangStdenv, rocmPackages_6.rocmClangStdenv, rocmPackages_6.stdenv)
  • rocmPackages.migraphx (rocmPackages_6.migraphx)
  • rocmPackages.miopen (rocmPackages.miopen-hip, rocmPackages_6.miopen, rocmPackages_6.miopen-hip)
  • rocmPackages.mivisionx (rocmPackages.mivisionx-hip, rocmPackages_6.mivisionx, rocmPackages_6.mivisionx-hip)
  • rocmPackages.mivisionx-cpu (rocmPackages_6.mivisionx-cpu)
  • rocmPackages.mpi (rocmPackages.openmpi, rocmPackages_6.mpi, rocmPackages_6.openmpi)
  • rocmPackages.mpi.dev (rocmPackages.openmpi.dev, rocmPackages_6.mpi.dev, rocmPackages_6.openmpi.dev)
  • rocmPackages.mpi.man (rocmPackages.openmpi.man, rocmPackages_6.mpi.man, rocmPackages_6.openmpi.man)
  • rocmPackages.mscclpp (rocmPackages_6.mscclpp)
  • rocmPackages.rccl (rocmPackages_6.rccl)
  • rocmPackages.rdc (rocmPackages_6.rdc)
  • rocmPackages.rdc.doc (rocmPackages_6.rdc.doc)
  • rocmPackages.rocalution (rocmPackages_6.rocalution)
  • rocmPackages.rocblas (rocmPackages_6.rocblas)
  • rocmPackages.rocdbgapi (rocmPackages_6.rocdbgapi)
  • rocmPackages.rocdbgapi.doc (rocmPackages_6.rocdbgapi.doc)
  • rocmPackages.rocfft (rocmPackages_6.rocfft)
  • rocmPackages.rocgdb (rocmPackages_6.rocgdb)
  • rocmPackages.rocm-bandwidth-test (rocmPackages_6.rocm-bandwidth-test)
  • rocmPackages.rocm-cmake (rocmPackages_6.rocm-cmake)
  • rocmPackages.rocm-comgr (rocmPackages_6.rocm-comgr)
  • rocmPackages.rocm-core (rocmPackages_6.rocm-core)
  • rocmPackages.rocm-device-libs (rocmPackages_6.rocm-device-libs)
  • rocmPackages.rocm-docs-core (rocmPackages_6.rocm-docs-core)
  • rocmPackages.rocm-docs-core.dist (rocmPackages_6.rocm-docs-core.dist)
  • rocmPackages.rocm-smi (rocmPackages_6.rocm-smi)
  • rocmPackages.rocm-tests (rocmPackages_6.rocm-tests)
  • rocmPackages.rocmPath (rocmPackages_6.rocmPath)
  • rocmPackages.rocminfo (rocmPackages_6.rocminfo)
  • rocmPackages.rocmlir (rocmPackages.rocmlir-rock, rocmPackages_6.rocmlir, rocmPackages_6.rocmlir-rock)
  • rocmPackages.rocprim (rocmPackages_6.rocprim)
  • rocmPackages.rocprofiler (rocmPackages_6.rocprofiler)
  • rocmPackages.rocprofiler-register (rocmPackages_6.rocprofiler-register)
  • rocmPackages.rocr-debug-agent (rocmPackages_6.rocr-debug-agent)
  • rocmPackages.rocrand (rocmPackages_6.rocrand)
  • rocmPackages.rocsolver (rocmPackages_6.rocsolver)
  • rocmPackages.rocsparse (rocmPackages_6.rocsparse)
  • rocmPackages.rocthrust (rocmPackages_6.rocthrust)
  • rocmPackages.roctracer (rocmPackages_6.roctracer)
  • rocmPackages.rocwmma (rocmPackages_6.rocwmma)
  • rocmPackages.rpp (rocmPackages.rpp-hip, rocmPackages_6.rpp, rocmPackages_6.rpp-hip)
  • rocmPackages.rpp-cpu (rocmPackages_6.rpp-cpu)
  • rocmPackages.tensile (rocmPackages_6.tensile)
  • rocmPackages.tensile.dist (rocmPackages_6.tensile.dist)
  • zluda

Error logs: `x86_64-linux`
llama-cpp-rocm
Job completed: /build/mmq-instance-q5_0-gfx908-4eed84.o
Job completed: /build/mmq-instance-q5_0-gfx90a-4aae84.o
Job completed: /build/mmq-instance-q5_0-gfx942-67d1da.o
Job completed: ggml/src/ggml-hip/CMakeFiles/ggml-hip.dir/__/ggml-cuda/template-instances/mmq-instance-q5_0.cu.o
[191/213] Building HIP object ggml/src/ggml-hip/CMakeFiles/ggml-hip.dir/__/ggml-cuda/template-instances/mmq-instance-q2_k.cu.o
Job completed: /build/mmq-instance-q2_k-gfx1010-671ae6.o
Job completed: /build/mmq-instance-q2_k-gfx1030-3d38cd.o
Job completed: /build/mmq-instance-q2_k-gfx1100-d8e9fa.o
Job completed: /build/mmq-instance-q2_k-gfx1101-e3873e.o
Job completed: /build/mmq-instance-q2_k-gfx1102-f8663d.o
Job completed: /build/mmq-instance-q2_k-gfx1151-92a513.o
Job completed: /build/mmq-instance-q2_k-gfx1200-6c9408.o
Job completed: /build/mmq-instance-q2_k-gfx1201-019565.o
Job completed: /build/mmq-instance-q2_k-gfx900-09a182.o
Job completed: /build/mmq-instance-q2_k-gfx906-4a4bf7.o
Job completed: /build/mmq-instance-q2_k-gfx908-05e6ce.o
Job completed: /build/mmq-instance-q2_k-gfx90a-c5abc9.o
Job completed: /build/mmq-instance-q2_k-gfx942-c35912.o
Job completed: ggml/src/ggml-hip/CMakeFiles/ggml-hip.dir/__/ggml-cuda/template-instances/mmq-instance-q2_k.cu.o
ninja: build stopped: subcommand failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet