HIP: use v_dot2_f32_f16 instruction for FA#15884
Merged
JohannesGaessler merged 1 commit intoggml-org:masterfrom Sep 9, 2025
Merged
HIP: use v_dot2_f32_f16 instruction for FA#15884JohannesGaessler merged 1 commit intoggml-org:masterfrom
JohannesGaessler merged 1 commit intoggml-org:masterfrom
Conversation
slaren
approved these changes
Sep 9, 2025
Contributor
|
JFYI: according to my tests/CI, this seems to have broken hipblas compilation for gfx803 (at least, as the build stops there) #15936 |
18 tasks
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Sep 27, 2025
This reverts commit 17bc5a8.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Sep 29, 2025
This reverts commit 17bc5a8.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Oct 4, 2025
This reverts commit 17bc5a8.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Oct 26, 2025
This reverts commit 17bc5a8.
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/iacopPBK/llama.cpp-gfx906 . The fork uses an instruction for FP16 multiply-add with FP32 accumulation. This PR adopts the same instruction for the tile FA kernel.