rocmPackages.rocm-core: fix find_package(rocm-core)#438685
Merged
GaetanLepage merged 2 commits intoNixOS:masterfrom Sep 4, 2025
Merged
rocmPackages.rocm-core: fix find_package(rocm-core)#438685GaetanLepage merged 2 commits intoNixOS:masterfrom
GaetanLepage merged 2 commits intoNixOS:masterfrom
Conversation
6d89bfd to
3cd0dce
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2530 |
Member
Author
|
Asked in https://matrix.to/#/#infra:nixos.org, @mweinelt says it should be ok to go via master. |
GaetanLepage
approved these changes
Sep 1, 2025
Contributor
GaetanLepage
left a comment
There was a problem hiding this comment.
Minor (non-blocking) nits.
Overall, LGTM.
Comment on lines
40
to
45
Contributor
There was a problem hiding this comment.
Ideally, those should use lib.cmakeFeature, but this is out of scope for this commit.
Member
Author
There was a problem hiding this comment.
I can look at applying a rocm-modules/ wide fix for these separately - there are a lot 😅
3cd0dce to
61e2c0c
Compare
18 tasks
Contributor
|
Is |
Member
Author
|
Yeah - rerun already in progress |
Member
Author
|
GaetanLepage
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_package(rocm-core) was failing because the generated
rocm-core-config.cmakehad broken paths.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.